search

grpc / grpc-web

gRPC for Web Clients
https://grpc.io
Apache License 2.0
8.46k stars 762 forks source link

Expose getName() in MethodDescriptor and fix TS definitions. #1289

Closed sampajano closed 1 year ago

sampajano commented 1 year ago

Backgrounds:

  1. MethodDescriptor methods were exposed to match TS definition but later removed in #1199 due to internal code size increase.
  2. getName() still seemed useful to some users per discussion in https://github.com/grpc/grpc-web/issues/1285

Hence we're re-exposing only the getName() method on MethodDescriptor, hoping it won't cause a code size issue internally and also address some user needs.

dennycd commented 1 year ago

lgtm