upgrade `google-protobuf` version to fix bundle size issues

grpc / grpc-web

gRPC for Web Clients

https://grpc.io

Apache License 2.0

8.6k stars 765 forks source link

upgrade `google-protobuf` version to fix bundle size issues #1291

Open sayjeyhi opened 1 year ago

sayjeyhi commented 1 year ago

Based on this issue: https://github.com/protocolbuffers/protobuf-javascript/issues/124 on google-protobuf the new changes fixed and reduced the bundle size. So here we upgrade google-protobuf version to fix bundle size issues.

linux-foundation-easycla[bot] commented 1 year ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: sayjeyhi / name: Jafar Rezaei (c0927138592f91ad5e182bf543974da245e20611)

sayjeyhi commented 1 year ago

This will close: https://github.com/grpc/grpc-web/issues/270

sampajano commented 1 year ago

@sayjeyhi Hi Jafar, thanks so much your contributions here! Really appreciate your initiative and efforts here! ❤️

Although.. when i just checked bundle size for google-protobuf again i've noticed it has reverted to original size (and actually a little bit higher than that)..

Screen Shot 2022-10-11 at 4 52 47 PM

I'm guessing it's due to this PR below: https://github.com/protocolbuffers/protobuf-javascript/pull/143

I wonder if you have any ideas on the above PR and whether it can be solved?

Thanks a lot!