search

grpc / grpc-web

gRPC for Web Clients
https://grpc.io
Apache License 2.0
8.6k stars 765 forks source link

CORS spec and `Access-Control-Expose-Headers` #1319

Closed fracek closed 1 year ago

fracek commented 1 year ago

I'm updating apisix's grpc-web plugin to follow the spec more closely and I noticed that the spec doesn't explicitly mention Access-Control-Expose-Headers.

Setting Access-Control-Expose-Headers to include grpc-status,grpc-message is required to have a working grcp-web setup so I believe the spec should be updated to reflect that.

What's your thoughts about this?

sampajano commented 1 year ago

@fracek Thanks so much for pointing it out! Good point! Will add it thanks!