search

grpc / grpc-web

gRPC for Web Clients
https://grpc.io
Apache License 2.0
8.59k stars 765 forks source link

Update ES6 .d.ts imports with comment about corresponding proto import path #1330

Closed gonzojive closed 12 months ago

gonzojive commented 1 year ago

https://github.com/grpc/grpc-web/pull/1313 updated the code generator to print a // proto import: "foo/bar.proto" suffix for each import statement for the generated gRPC-web client code. This commit updates ensures the .d.ts file output by grpc-web contains the same type of comments.

gonzojive commented 1 year ago

Thanks. I just merged in the latest changes. I think @sampajano will need to trigger the tests and complete the merge.

sampajano commented 1 year ago

Thanks. I just merged in the latest changes. I think @sampajano will need to trigger the tests and complete the merge.

@gonzojive Yes will do! Thanks again for the change!