search

grpc / grpc-web

gRPC for Web Clients
https://grpc.io
Apache License 2.0
8.59k stars 765 forks source link

Use cloned init_submodules.sh in prereqs (#1349) #1352

Closed Kaszanas closed 3 months ago

Kaszanas commented 1 year ago

The problem with building the docker-compose example was due to the additional line copying the init_submodule.sh script from the context. The line just above was cloning the repository though, so there is no need to COPY that script.

This is supposed to be solving the issue: https://github.com/grpc/grpc-web/issues/1349

While solving this, another issue was discovered:

Kaszanas commented 1 year ago

Sure thing,

Yes there's one closed issue, and another one which explores further another error down the line.

I'm running Docker on Windows. As I have been performing a clean install recently I have the most recent Docker version (for a more precise answer I'd have to verify).

There may be a couple of things to check:

sampajano commented 1 year ago

Sure thing,

Yes there's one closed issue, and another one which explores further another error down the line.

Yes.. have understood about that :)

I'm running Docker on Windows. As I have been performing a clean install recently I have the most recent Docker version (for a more precise answer I'd have to verify).

Thanks for clarifying on the platform!

I'm running Docker 20.10.8 on Mac, and i was not able to see the same error you did.

That is, i can successfully build using this command:

docker-compose build prereqs

I guess that's the same command you're running and it's failing?

I'm wondering what is the difference here.

There may be a couple of things to check:

  • is the context passed correctly from the docker-compose vs dockerfile?

I'm not sure what exactly to check here. Could you clarify? Do you have a theory on what might be missing?

Kaszanas commented 1 year ago

I'm running the docker compose command which is supposed to build and run all images I guess. This is following the instructions from the TypeScript example. I will see if the docker build command by itself runs as intended.

My immediate thought (a guess) is that there's something off in passing the context to docker.

sampajano commented 1 year ago

I'm running the docker compose command which is supposed to build and run all images I guess. This is following the instructions from the TypeScript example. I will see if the docker build command by itself runs as intended.

I was running docker compose as well.. But it was succeeding for me..

The command i used is:

docker-compose build prereqs
sampajano commented 3 months ago

Hi :) I'm closing this due to inactivity. Feel free to open another PR when needed. Thanks! :)

Kaszanas commented 3 months ago

No problem @sampajano at some point this may resurface for someone else ;)

sampajano commented 3 months ago

@Kaszanas thank you :) yes definitely can. We'll address it when it comes :)