grpc / grpc-web

gRPC for Web Clients
https://grpc.io
Apache License 2.0
8.45k stars 761 forks source link

"require is not defined" error when using with Vite #1361

Open wutipong opened 9 months ago

wutipong commented 9 months ago

I'm trying to add grpc-web client into a Sveltekit-based application. Here's the page load function (in Typescript, if that matters)

export const load: PageLoad = async ({ fetch, url }) => {
    const client = new MetaServiceClient("http://localhost:9000")
    const r = await client.list(new MetaListRequest(), null)

    console.log(r)
    return {
        ok: true
    }
};

And the output is

4:46:58 AM [vite] Error when evaluating SSR module /src/lib/grpc/service_pb.js:
|- ReferenceError: require is not defined
    at eval (/home/noom/mangaweb3-frontend/src/lib/grpc/service_pb.js:15:12)
    at instantiateModule (file:///home/noom/mangaweb3-frontend/node_modules/vite/dist/node/chunks/dep-df561101.js:55974:15)

where service_pb.js is the generated js file.

adlion commented 8 months ago

+1

ap0xF commented 8 months ago

+1

rayshoo commented 3 months ago

+1

sampajano commented 3 months ago

@adlion @ap0xF @rayshoo Thanks for the interests!

I think this comment explained why require doesn't work directly, and provided an alternative way to make it work, and a demo app (https://github.com/a2not/vite-grpc-web).

Could you take a look at the solution and see if it works for you?

We will also look into improving this workflow to make it easier for Vite users as we go through the Typescript-ification of our codebase.

Thanks! 😃

rayshoo commented 3 months ago

@sampajano Thank you for your comment. I had already confirmed this through many searches, but unfortunately, it didn't work for me as I created and used the proto stub file with javascript rather than typescript.(vite is also used as javscript) However, I did a simple build test in the repository you shared. It definitely works well. I need to study TypeScript, which I've been putting off. Thank you!!

sampajano commented 3 months ago

@rayshoo Ahh i see! Glad to hear that the demo app works at least! Typescript seems like the right bet indeed.. We are interested in improving our TS support going forward as well!