search

grpc / grpc-web

gRPC for Web Clients
https://grpc.io
Apache License 2.0
8.59k stars 765 forks source link

Output comments for imports in .d.ts like '// proto: "foo/bar.proto"' #1365

Closed gonzojive closed 12 months ago

gonzojive commented 1 year ago

Followup to https://github.com/grpc/grpc-web/pull/1313 for .d.ts files.

As with https://github.com/grpc/grpc-web/pull/1313, this helps with diagnostic and with rewriting imports generated by grpc-web.

gonzojive commented 1 year ago

It looks like I already implemented this and forgot: https://github.com/grpc/grpc-web/pull/1330

sampajano commented 1 year ago

It looks like I already implemented this and forgot: #1330

Hey Sorry for letting that one slip! I've now approved that change!

Thanks a lot for the change (twice)!

I guess we don't need this change anymore?

sampajano commented 12 months ago

Closing this in favor of https://github.com/grpc/grpc-web/pull/1330. Thanks again for contributing!