search

grpc / grpc-web

gRPC for Web Clients
https://grpc.io
Apache License 2.0
8.45k stars 760 forks source link

Status of streaming with the binary wire format #1396

Closed dimo414 closed 5 months ago

dimo414 commented 5 months ago

The readme section for mode=grpcweb notes that "Only unary calls are supported for now". This line dates back to 2018. Is this still correct? Are there any plans to resolve this wire format incompatibility?

sampajano commented 5 months ago

Yeah i believe this is still true. And unfortunately no, nothing is planned around improving streaming support in binary mode.. :)

sampajano commented 5 months ago

I'll close this issue for now. Please feel free to open another feature request issue if there's a good reason why it would be beneficial to add this support. thanks! :)

dimo414 commented 5 months ago

Is the expectation then that we should just always use the text format? It's a really surprising limitation of the binary format that it lacks features the text format supports.

At a minimum it would be helpful to remove the "for now" if there are not actually any plans to resolve this discrepancy.

sampajano commented 5 months ago

Is the expectation then that we should just always use the text format? It's a really surprising limitation of the binary format that it lacks features the text format supports.

For streaming i guess so. I was not involved in the earlier design/implementations, but afaiu there's some limitations with how messages are encoded/decoded which makes streaming decode not feasible when binary format is used..

At a minimum it would be helpful to remove the "for now" if there are not actually any plans to resolve this discrepancy.

That's quite fair! Let me remove that "for now" text then! :)