search

grpc / grpc-web

gRPC for Web Clients
https://grpc.io
Apache License 2.0
8.45k stars 760 forks source link

Update http2_protocol_options pattern #1397

Closed dimo414 closed 5 months ago

dimo414 commented 5 months ago

In my Envoy logs I see a number of entries like this:

[2024-01-22 15:44:47.698][620][warning][misc] [source/common/protobuf/message_validator_impl.cc:21] Deprecated field: type envoy.config.cluster.v3.Cluster Using deprecated option 'envoy.config.cluster.v3.Cluster.http2_protocol_options' from file cluster.proto. This configuration will be removed from Envoy soon. Please see https://www.envoyproxy.io/docs/envoy/latest/version_history/version_history for details. If continued use of this field is absolutely necessary, see https://www.envoyproxy.io/docs/envoy/latest/configuration/operations/runtime#using-runtime-overrides-for-deprecated-features for how to apply a temporary and highly discouraged override.

I believe this stems from https://github.com/envoyproxy/envoy/pull/14079 (@alyssawilk) but the examples and tests in this repo haven't been updated. I lifted this diff from that PR and applied to all mentions of this string in this repo. I verified this change works in my Envoy application.

linux-foundation-easycla[bot] commented 5 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

alyssawilk commented 5 months ago

yeah so IMO it's better to use new config but I've also had conversations with the envoy API shepherds about removing those warnings as we're no longer removing deprecated config. they suggested keeping the warnings last time I checked but maybe they're open to it now? either way thanks for the fix!