search

grpc / grpc-web

gRPC for Web Clients
https://grpc.io
Apache License 2.0
8.45k stars 760 forks source link

stream.cancel doesn't close the stream #1412

Open kanekv opened 3 months ago

kanekv commented 3 months ago

Calling stream.cancel on the client doesn't close stream on the server.

sampajano commented 3 months ago

@kanekv Thanks for the ping again.. This is a known issue..

I know i've made a promise in https://github.com/grpc/grpc-web/issues/946 as you asked last year, but i'm sorry i'm not able to get to it still yet!

We're recently working on a Closure dependency migration (along with Typescript-ification), due to closure entering maintenance mode.

The fix needs to be done in Closure and hence it depends on that migration to finish..

I'm long due on this area so i will work on this issue as the first follow-up once that's finished.. Thanks for the patience in the meantime..

sampajano commented 3 months ago

FYI, tracking the above work in the following issue :) https://github.com/grpc/grpc-web/issues/1414