search

grpc / grpc-web

gRPC for Web Clients
https://grpc.io
Apache License 2.0
8.45k stars 760 forks source link

`protoc-plugin` image is currently broken #1449

Open sampajano opened 1 week ago

sampajano commented 1 week ago

See: https://github.com/grpc/grpc-web/pull/1446#issuecomment-2187997625

The protoc_plugin image is broken since https://github.com/grpc/grpc-web/pull/1445

@benjaminp FYI :)

benjaminp commented 1 week ago

I'm afraid I can't spend a huge amount of time digging into all ways there are to build the generator at the moment in this repo. (There's also a build.zig file in the generator directory. What's the used for?) Possibly everything should be reverted until that's in a better place.

sampajano commented 1 week ago

@benjaminp No worries! Appreciate your effort in trying to help anyways!!

build.zig is used for building for ARM architecture (workflow. Whereas other binaries are built using platform-specific workflows: https://github.com/grpc/grpc-web/tree/master/.github/workflows

It's ok.. I think we have to move forward anyways.. I've temporarily disabled protoc_plugin in CI so BUILD is green now. But we have to fix it for a new release to be made :)

sampajano commented 1 week ago

Note to myself: we are currently pinning the protobuf submodule version:

https://github.com/grpc/grpc-web/blob/20790fc2597971b6eaada36fbeaf5d3c95d54d93/scripts/init_submodules.sh#L19

This is for 2 reasons:

  1. For protobuf JS dependencies
  2. For building the generator binary

Ideally, (1) should be tackled first — by mmoving to https://github.com/protocolbuffers/protobuf-javascript, since protobuf has removed JS from its repo.

And then (2) — ensuring Makefile work as before.