search

grpc / grpc-web

gRPC for Web Clients
https://grpc.io
Apache License 2.0
8.66k stars 764 forks source link

Bazel bzlmod support for grpc-web. #1456

Closed gonzojive closed 2 months ago

gonzojive commented 3 months ago

Update the bazel-based build of grpc-web to use bzlmod. Delete the WORKSPACE file since it is unused.

Output of bazel mod graph:

<root> (grpc-web@1.6.0)
├───grpc@1.65.0 
│   ├───protobuf@27.1 (*) 
│   ├───rules_cc@0.0.9 (*) 
│   ├───rules_proto@6.0.2 (*) 
│   ├───abseil-cpp@20240116.0 
│   │   ├───bazel_skylib@1.6.1 (*) 
│   │   ├───googletest@1.14.0.bcr.1 (*) 
│   │   └───platforms@0.0.10 (*) 
│   ├───apple_support@1.15.1 
│   │   ├───bazel_skylib@1.6.1 (*) 
│   │   └───platforms@0.0.10 (*) 
│   ├───bazel_skylib@1.6.1 
│   │   └───platforms@0.0.10 (*) 
│   ├───boringssl@0.0.0-20230215-5c22014 
│   │   ├───platforms@0.0.10 (*) 
│   │   └───rules_cc@0.0.9 (*) 
│   ├───c-ares@1.15.0 
│   │   ├───bazel_skylib@1.6.1 (*) 
│   │   └───platforms@0.0.10 (*) 
│   ├───gazelle@0.36.0 
│   │   ├───bazel_features@1.11.0 (*) 
│   │   ├───bazel_skylib@1.6.1 (*) 
│   │   ├───protobuf@27.1 (*) 
│   │   ├───rules_go@0.48.0 (*) 
│   │   └───rules_proto@6.0.2 (*) 
│   ├───google_benchmark@1.8.4 
│   │   ├───bazel_skylib@1.6.1 (*) 
│   │   ├───platforms@0.0.10 (*) 
│   │   ├───rules_cc@0.0.9 (*) 
│   │   ├───libpfm@4.11.0 
│   │   │   ├───platforms@0.0.10 (*) 
│   │   │   └───rules_foreign_cc@0.10.1 (*) 
│   │   └───rules_foreign_cc@0.10.1 
│   │       ├───bazel_skylib@1.6.1 (*) 
│   │       ├───platforms@0.0.10 (*) 
│   │       └───rules_python@0.31.0 (*) 
│   ├───googleapis@0.0.0-20240326-1c8d509c5 
│   │   ├───protobuf@27.1 (*) 
│   │   ├───rules_go@0.48.0 (*) 
│   │   ├───rules_proto@6.0.2 (*) 
│   │   ├───rules_python@0.31.0 (*) 
│   │   └───grpc-java@1.64.0 
│   │       ├───protobuf@27.1 (*) 
│   │       ├───rules_cc@0.0.9 (*) 
│   │       ├───rules_go@0.48.0 (*) 
│   │       ├───rules_java@7.6.5 (*) 
│   │       ├───rules_jvm_external@6.0 (*) 
│   │       └───rules_proto@6.0.2 (*) 
│   ├───googletest@1.14.0.bcr.1 
│   │   ├───abseil-cpp@20240116.0 (*) 
│   │   ├───platforms@0.0.10 (*) 
│   │   ├───re2@2023-09-01 (*) 
│   │   └───rules_cc@0.0.9 (*) 
│   ├───opentelemetry-cpp@1.14.2 
│   │   ├───abseil-cpp@20240116.0 (*) 
│   │   ├───bazel_skylib@1.6.1 (*) 
│   │   ├───platforms@0.0.10 (*) 
│   │   ├───prometheus-cpp@1.2.4 (*) 
│   │   ├───protobuf@27.1 (*) 
│   │   ├───rules_proto@6.0.2 (*) 
│   │   ├───zlib@1.3.1.bcr.3 (*) 
│   │   ├───curl@8.4.0 
│   │   │   └───platforms@0.0.10 (*) 
│   │   ├───nlohmann_json@3.11.3 
│   │   ├───opentelemetry-proto@1.1.0 
│   │   │   └───rules_proto@6.0.2 (*) 
│   │   ├───opentracing-cpp@1.6.0 
│   │   └───upb@0.0.0-20230907-e7430e6 
│   │       ├───abseil-cpp@20240116.0 (*) 
│   │       ├───bazel_skylib@1.6.1 (*) 
│   │       ├───platforms@0.0.10 (*) 
│   │       ├───protobuf@27.1 (*) 
│   │       ├───rules_cc@0.0.9 (*) 
│   │       ├───rules_pkg@0.7.0 (*) 
│   │       ├───rules_proto@6.0.2 (*) 
│   │       └───rules_python@0.31.0 (*) 
│   ├───platforms@0.0.10 
│   │   └───rules_license@0.0.7 (*) 
│   ├───prometheus-cpp@1.2.4 
│   │   ├───boringssl@0.0.0-20230215-5c22014 (*) 
│   │   ├───platforms@0.0.10 (*) 
│   │   ├───rules_cc@0.0.9 (*) 
│   │   └───zlib@1.3.1.bcr.3 (*) 
│   ├───re2@2023-09-01 
│   │   ├───abseil-cpp@20240116.0 (*) 
│   │   ├───platforms@0.0.10 (*) 
│   │   ├───rules_cc@0.0.9 (*) 
│   │   ├───rules_python@0.31.0 (*) 
│   │   └───pybind11_bazel@2.11.1 
│   │       ├───platforms@0.0.10 (*) 
│   │       └───rules_cc@0.0.9 (*) 
│   ├───rules_apple@3.5.1 
│   │   ├───apple_support@1.15.1 (*) 
│   │   ├───bazel_skylib@1.6.1 (*) 
│   │   ├───platforms@0.0.10 (*) 
│   │   └───rules_swift@1.18.0 
│   │       ├───apple_support@1.15.1 (*) 
│   │       ├───bazel_features@1.11.0 (*) 
│   │       ├───bazel_skylib@1.6.1 (*) 
│   │       ├───nlohmann_json@3.11.3 (*) 
│   │       ├───platforms@0.0.10 (*) 
│   │       ├───protobuf@27.1 (*) 
│   │       ├───rules_cc@0.0.9 (*) 
│   │       └───rules_proto@6.0.2 (*) 
│   ├───rules_go@0.48.0 
│   │   ├───bazel_features@1.11.0 (*) 
│   │   ├───bazel_skylib@1.6.1 (*) 
│   │   ├───gazelle@0.36.0 (*) 
│   │   ├───platforms@0.0.10 (*) 
│   │   ├───protobuf@27.1 (*) 
│   │   └───rules_proto@6.0.2 (*) 
│   ├───rules_java@7.6.5 
│   │   ├───bazel_features@1.11.0 (*) 
│   │   ├───bazel_skylib@1.6.1 (*) 
│   │   ├───platforms@0.0.10 (*) 
│   │   ├───rules_cc@0.0.9 (*) 
│   │   ├───rules_license@0.0.7 (*) 
│   │   └───rules_proto@6.0.2 (*) 
│   ├───rules_python@0.31.0 
│   │   ├───bazel_features@1.11.0 (*) 
│   │   ├───bazel_skylib@1.6.1 (*) 
│   │   ├───platforms@0.0.10 (*) 
│   │   ├───protobuf@27.1 (*) 
│   │   └───rules_proto@6.0.2 (*) 
│   └───zlib@1.3.1.bcr.3 
│       ├───platforms@0.0.10 (*) 
│       └───rules_cc@0.0.9 (*) 
├───protobuf@27.1 
│   ├───abseil-cpp@20240116.0 (*) 
│   ├───bazel_skylib@1.6.1 (*) 
│   ├───platforms@0.0.10 (*) 
│   ├───rules_cc@0.0.9 (*) 
│   ├───rules_java@7.6.5 (*) 
│   ├───rules_proto@6.0.2 (*) 
│   ├───rules_python@0.31.0 (*) 
│   ├───zlib@1.3.1.bcr.3 (*) 
│   ├───jsoncpp@1.9.5 
│   ├───rules_jvm_external@6.0 
│   │   ├───bazel_skylib@1.6.1 (*) 
│   │   ├───platforms@0.0.10 (*) 
│   │   ├───rules_java@7.6.5 (*) 
│   │   ├───rules_kotlin@1.9.0 
│   │   │   ├───bazel_skylib@1.6.1 (*) 
│   │   │   ├───platforms@0.0.10 (*) 
│   │   │   ├───rules_cc@0.0.9 (*) 
│   │   │   ├───rules_java@7.6.5 (*) 
│   │   │   ├───rules_pkg@0.7.0 (*) 
│   │   │   ├───rules_proto@6.0.2 (*) 
│   │   │   ├───rules_python@0.31.0 (*) 
│   │   │   └───stardoc@0.5.6 (*) 
│   │   └───stardoc@0.5.6 
│   │       ├───bazel_skylib@1.6.1 (*) 
│   │       ├───rules_java@7.6.5 (*) 
│   │       └───rules_license@0.0.7 (*) 
│   └───rules_pkg@0.7.0 
│       ├───bazel_skylib@1.6.1 (*) 
│       ├───rules_license@0.0.7 (*) 
│       └───rules_python@0.31.0 (*) 
├───rules_cc@0.0.9 
│   └───platforms@0.0.10 (*) 
└───rules_proto@6.0.2 
    ├───bazel_skylib@1.6.1 (*) 
    ├───rules_cc@0.0.9 (*) 
    ├───bazel_features@1.11.0 
    │   └───bazel_skylib@1.6.1 (*) 
    └───rules_license@0.0.7

fixes https://github.com/grpc/grpc-web/issues/1457

gonzojive commented 3 months ago

Would someone on the gprc-web team be interested in being the owner for the grpc-web module in the central registry? I can update https://github.com/bazelbuild/bazel-central-registry/pull/2541/files#diff-75ca774261b28f5a230b37542dc98c9611065b2ae99c7fec5430d164e8db5301 accordingly.

I think the release binaries will also need to be updated to include a zip of the source that has a guaranteed checksum (unlike github's automatic source archives).

sampajano commented 3 months ago

Would someone on the gprc-web team be interested in being the owner for the grpc-web module in the central registry? I can update https://github.com/bazelbuild/bazel-central-registry/pull/2541/files#diff-75ca774261b28f5a230b37542dc98c9611065b2ae99c7fec5430d164e8db5301 accordingly.

I think the release binaries will also need to be updated to include a zip of the source that has a guaranteed checksum (unlike github's automatic source archives).

Aha thanks for asking!

I'm not familiar with the system and not sure what the maintenance work entails..

But would be happy to help look into maintaining it for future releases once it's already been established (thanks for your PR!) and there's a clear steps to follow for keeping it up-to-date 😃

gonzojive commented 2 months ago

Would someone on the gprc-web team be interested in being the owner for the grpc-web module in the central registry? I can update bazelbuild/bazel-central-registry#2541 (files) accordingly. I think the release binaries will also need to be updated to include a zip of the source that has a guaranteed checksum (unlike github's automatic source archives).

Aha thanks for asking!

I'm not familiar with the system and not sure what the maintenance work entails..

But would be happy to help look into maintaining it for future releases once it's already been established (thanks for your PR!) and there's a clear steps to follow for keeping it up-to-date 😃

https://github.com/bazelbuild/bazel-central-registry/blob/main/docs/README.md has the responsibilities of a maintainer:

Every module must have a list of maintainers provided in its metadata.json file. The first contributor to a Bazel module is likely be appointed as the module maintainer. Anyone can apply to be a maintainer of some specific modules. Library authors / rule authors / Bazel users who have special interest on some projects can be module maintainers.

Responsibilities of a module maintainer

  • Review and approve changes related to the designated Bazel module.
  • Update new versions for the designated Bazel module.
  • Serve as the contact point for issues of their assigned module

There's no need to commit to any of that to submit this PR, though.

sampajano commented 2 months ago

There's no need to commit to any of that to submit this PR, though.

Oh ok!! Thanks for clarifying! Will merge it now! 😊

sampajano commented 2 months ago

https://github.com/bazelbuild/bazel-central-registry/blob/main/docs/README.md has the responsibilities of a maintainer:

Every module must have a list of maintainers provided in its metadata.json file. The first contributor to a Bazel module is likely be appointed as the module maintainer. Anyone can apply to be a maintainer of some specific modules. Library authors / rule authors / Bazel users who have special interest on some projects can be module maintainers. Responsibilities of a module maintainer

  • Review and approve changes related to the designated Bazel module.
  • Update new versions for the designated Bazel module.
  • Serve as the contact point for issues of their assigned module

There's no need to commit to any of that to submit this PR, though.

Aha and just noticed the maintainer responsibilities! Thanks for linking them!

Yeah I think i'll be happy to be the maintainer of the Bazel module (given my role :)). And I'll look into how to update the version when we make new releases.

Thanks a lot for the contribution!