search

grpc / grpc.github.io

The grpc.io website. (on GitHub pages)
276 stars 381 forks source link

Add quickstart and tutorial for Dart. #629

Closed jakobr-google closed 6 years ago

jakobr-google commented 6 years ago

Note: The repo URLs point to where the repository will be after it's moved to the grpc organization on GitHub, so this PR should only be merged after the repo has been moved.

jakobr-google commented 6 years ago

cc @mit-mit

jtattermusch commented 6 years ago

As this is a bigger change to grpc.io, I'll require @LisaFC 's approval. Lisa, can you please review?

Also, let's not merge before the dart repository is migrated to grpc/grpc-dart.

jakobr-google commented 6 years ago

Addressed review feedback. PTAL.

cc @mravn-google - could you check out the Dart code sample in this PR, please?

mit-mit commented 6 years ago

Thanks Lisa, I pushed changes for those two links. PTAL!

LisaFC commented 6 years ago

Actually, before I squash and merge - one tiny issue (that's my fault because it's hard to write HTML tags in a PR comment window): there's a space between the anchor tag and the text "filing issues" in both links, which may look odd when rendered - if you take the space out (in both docs) we're good to go!

mit-mit commented 6 years ago

Done!

mit-mit commented 6 years ago

cc @LisaFC anything else we need here?