standardize path resolution for usage of githuburl variable

grpc / grpc.github.io

The grpc.io website. (on GitHub pages)

276 stars 381 forks source link

standardize path resolution for usage of githuburl variable #644

Closed nilslice closed 5 years ago

nilslice commented 6 years ago

fixes Github 'Edit' links on docs pages where a // is introduced, i.e. https://github.com/grpc/grpc.github.io//edit/master/docs/index.html

thelinuxfoundation commented 6 years ago

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

One or more commits are not associated with a GitHub user. The email used in the Git commit must match a verified email address in a GitHub user profile. For more information, please see https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/

Regards, CLA GitHub bot

thelinuxfoundation commented 6 years ago

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @nilslice isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards, CLA GitHub bot

nilslice commented 6 years ago

CLA signed... pending system auto-update (unsure of delay). Thanks!

thisisnotapril commented 5 years ago

@nilslice old PR here, wanted to check if you thought it was ready to go or if we should close for now? We're planning to move the site to Hugo soon and trying to clean up PRs before doing so. Thanks!

nilslice commented 5 years ago

@thisisnotapril - I believe this is still addressing an issue where links are occasionally broken because of inconsistency in the URL path. The PR makes these consistent. But, I can't build the blog anymore due to some old jekyll & bundler issues, so I can't verify 😆

Should be fine to merge, but it will also be OK to just close this if a new Hugo theme and config will replace the current site.

Thanks for checking!

thisisnotapril commented 5 years ago

@nilslice gotcha, thank you! I'm going to go ahead and close this for now and we can reopen post Hugo migration if needed.