Remove direct edits of composer.json

grpc / grpc.github.io

The grpc.io website. (on GitHub pages)

276 stars 381 forks source link

Remove direct edits of composer.json #714

Closed brontim closed 6 years ago

brontim commented 6 years ago

Directly editing composer.json is dangerous for those unfamiliar with it. The existing instructions could result in multiple require keys if misunderstood.
Direct edits also throw composer.json and composer.lock out of sync, requiring a manual re-sync.
The existing instructions referenced grpc/grpc 1.7.0, which is no longer available on packagist.org.

thelinuxfoundation commented 6 years ago

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @brontim isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards, CLA GitHub bot

brontim commented 6 years ago

Still waiting on that CLA. Anyone else is welcome to take these changes and run with them.

brontim commented 6 years ago

Still no CLA in the inbox.

hsaliak commented 6 years ago

@brontim any chance you managed to get past the CLA problems?

brontim commented 6 years ago

@hsaliak, sadly no. I've since given up trying.