Closed Warix3 closed 6 years ago
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, CLA GitHub bot
Bot bump
@Warix3 did you get the CLA email?
@carl-mastrangelo I did, and I had registered there.
Bot broken?
@Warix3 you're right we should update the example (and thanks for pointing that out!), but it's not the time yet:
The example says clone the v1.14.1 version of gRPC (git clone -b v1.14.1 https://github.com/grpc/grpc
) and that release still has the helloworld-from-cli
directory. We should update
the document as soon as v1.15.x is releases (it will contain the recent revamp of the C# examples).
see https://github.com/grpc/grpc/tree/v1.14.1/examples/csharp
@Warix3, can you please list out the exact steps you followed to sign the CLA starting from visiting https://identity.linuxfoundation.org/projects/cncf. We are trying to figure out where is the CLA process breaking for you. Thanks.
@srini100 Here's the list, I'm not 100% if it's like this because it was a few days ago but it's probably something like that:
Go to: https://identity.linuxfoundation.org/projects/cncf Click on link: "Sign up to contribute to this project as an individual" Choose option: "Log in with Google" Select my Google account Get redirected to the website Now I don't remember for sure what happened after that but what I know is that I was supposed to receive a registration email and it didn't come after a few hours so i requested it to be resent and then I got it and went on the site and linked my github account. And a weird thing happened when I tried to link my github account, when I first clicked the github icon I got a message saying I don't have a permission to do that action, then I tried it again and it worked. And that's pretty much it, after that I posted a comment in this thread.
@Warix3, can you please try the process all over again? Sorry for the trouble but linuxfoundation is telling us that your CLA is not active. Please note the steps and let us know if it still doesn't work.
Ok, this time there was an option to sign the license agreement. I think it'll work now.
So last time when you clicked on the github icon there was no option to sign the license agreement but this time the option was there? Did you receive the email immediately this time?
I didn't repeat the whole process, I just went to https://identity.linuxfoundation.org/projects/cncf and I had chosen the option to sign up as an individual and after that there was an option to request the email. I'm not sure how it's supposed to work. Maybe everything was fine, I just needed to revisit the https://identity.linuxfoundation.org/projects/cncf link. I don't remember if I tried revisiting it the first time. And the first time when I added my github account it didn't show me anything about requesting the signing email. I didn't know it was an actual step until now. Maybe you just need to redirect to https://identity.linuxfoundation.org/projects/cncf after registration or github account is added. Because revisiting the link is probably not the most intuitive step.
Thanks for the detail. We'll follow up with LF. You are good for now :-)
I've removed the referenced example because it doesn't exist in the examples directory. This probably needs to be adjusted.