grpc / grpc.github.io

The grpc.io website. (on GitHub pages)
276 stars 381 forks source link

Remove linked helloworld - it's not "Go Secure" #748

Closed theraphim closed 5 years ago

theraphim commented 5 years ago

https://github.com/kelseyhightower/helloworld is just a basic http server, having it linked here just confuses people.

thelinuxfoundation commented 5 years ago

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards, CLA GitHub bot

hsaliak commented 5 years ago

@theraphim thanks for sending this PR - I think the suggested change makes sense. Can you please confirm you have signed the CLA so that we can review the PR?

theraphim commented 5 years ago

Sorry for the delay, took a while fighting with linuxfoundation profile to change my email there :(

hsaliak commented 5 years ago

@theraphim thanks for the PR - merging it.