search

grpc / grpc.github.io

The grpc.io website. (on GitHub pages)
276 stars 381 forks source link

Web Quickstart for Echo example is broken #755

Closed annieoakley closed 5 years ago

annieoakley commented 5 years ago

When I try to follow the steps on https://grpc.io/docs/quickstart/web.html, $ docker-compose pull prereqs common node-server envoy commonjs-client fails for node-server:

ERROR: for node-server pull access denied for grpcweb/node-server, repository does not exist or may require 'docker login' ERROR: pull access denied for grpcweb/node-server, repository does not exist or may require 'docker login'

I am logged in with Docker, so that is not the issue.

I believe a recent change https://github.com/grpc/grpc-web/commit/3f4cc9e1dc697275e1473739871e78dc85183380 may have caused this.

annieoakley commented 5 years ago

@stanley-cheung could you please take a quick look?

stanley-cheung commented 5 years ago

Sorry I forgot to re-push the docker images after the latest release. They are pushed now. So this should work now:

$ docker-compose pull prereqs common node-server envoy commonjs-client
$ docker-compose up -d node-server envoy commonjs-client
jakepoz commented 5 years ago

Confirmed, it works for me now!