pass channel credentials as byte string

grpc / grpc.github.io

The grpc.io website. (on GitHub pages)

276 stars 381 forks source link

pass channel credentials as byte string #757

Closed ysangkok closed 5 years ago

ysangkok commented 5 years ago

As documented on https://grpc.io/grpc/python/grpc.html#grpc.ssl_channel_credentials

thelinuxfoundation commented 5 years ago

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @ysangkok isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards, CLA GitHub bot

ysangkok commented 5 years ago

OK, I signed

carl-mastrangelo commented 5 years ago

cc: @lidizheng

lidizheng commented 5 years ago

@ysangkok The changes are good, and they prevent Python3 users from failing. Can you make the same changes for the server part as well?

ysangkok commented 5 years ago

@lidizheng done

carl-mastrangelo commented 5 years ago

@lidizheng If you are happy I can merge.

carl-mastrangelo commented 5 years ago

@ysangkok Merged, Thanks!