Open mitchdraft opened 5 years ago
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, CLA GitHub bot
CLA signed
The change seems fine to me too. @murgatroid99 can you please take a look?
@murgatroid99 @nicolasnoble can you please rubber stamp, given that this is an example change it would be best if one of you looked over it.
@murgatroid99 @nicolasnoble @hsaliak are we OK to merge this one?
small change to the docs now that the node server api has changed
link to api: https://github.com/grpc/grpc-node/blob/master/packages/grpc-native-core/src/server.js#L948
the examples work with or without this change, but the change removes this warning message: