The path to Grpc.Tools in the example command for Linux(or macOS) does not exist

grpc / grpc.github.io

The grpc.io website. (on GitHub pages)

276 stars 381 forks source link

The path to Grpc.Tools in the example command for Linux(or macOS) does not exist #784

Closed ptrkrlsrd closed 5 years ago

ptrkrlsrd commented 5 years ago

Hey,

I belive there is a mistake in the path to Grpc.Tools in the example command for Linux in the documentation. When I tried running the example command displayed on the page (look below) I got an error saying that the path does not exist. It worked when I replaced the dot after tools in the current path (~.nuget/packages/grpc.tools.1.16.0/) with a slash, which resulted in a valid path: ~/.nuget/packages/grpc.tools/1.16.0/

thelinuxfoundation commented 5 years ago

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @ptrkrlsrd isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards, CLA GitHub bot

ptrkrlsrd commented 5 years ago

I signed it

carl-mastrangelo commented 5 years ago

@jtattermusch can you take a look?

jtattermusch commented 5 years ago

@ptrkrlsrd can you please sign the CLA? Otherwise I can't merge.

jtattermusch commented 5 years ago

Btw, in the upcoming release v1.17.0 we will have experimental support for codegen integration (see https://github.com/grpc/grpc/blob/master/src/csharp/BUILD-INTEGRATION.md), so juggling with grpc.tools path should not be necessary anymore.

ptrkrlsrd commented 5 years ago

@jtattermusch Hey, I signed it right after creating the pull request. But maybe something went wrong in the process. I'll have a look

Edit: Try again now. My profile on linuxfoundation.org seems to be updated now