search

grpc / grpc.github.io

The grpc.io website. (on GitHub pages)
276 stars 381 forks source link

Revert "Update to account for import error in generated python code" #785

Closed ericgribkoff closed 5 years ago

ericgribkoff commented 5 years ago

This reverts commit d9c953d22bb59f07d01e90053fee1673252e582c.

cc @hsaliak I'm not sure why this PR was merged. Unless I'm missing something, the reported error was because the user's protobuf file (not grpcio-tools itself) had a dependency on googleapis-common-protos. They should add this to their project's dependencies, it's not something required to use grpcio-tools or our quickstart or tutorial code.

hsaliak commented 5 years ago

Agreed - googleapis-common-protos is not something that was needed for gRPC. Apologies for missing this in the earlier review and thank you for catching it :+1:

lidizheng commented 5 years ago

Do we need to refer to googleapis-common-protos at some place of our tutorial? I guess it need proper documentation for that package, so people can use it properly.

  1. How to import it?
  2. What is the content?
  3. How to find documentation for each proto?
ericgribkoff commented 5 years ago

@lidizheng (who first noticed this; thanks!) - I don't think we actually need to mention the googleapis-common-protos package at all on grpc.io. As I understand it, these protos are mainly for use with the cloud library clients and their APIs. It might come into play for gRPC when you add the Status proto conversion support as a gRPC Python package, but it's not a dependency of our examples right now.

lidizheng commented 5 years ago

@hsaliak Can you give approval on this PR?