search

grpc / grpc.io

Repository for the gRPC website and documentation
https://grpc.io
Other
416 stars 437 forks source link

Update logo.svg #1362

Closed sahilk closed 1 week ago

sahilk commented 2 weeks ago

Cleaned up the diamond shapes. Too many elements in the older version. Reduced file size as well as a result.

sreenithi commented 2 weeks ago

hi @sahilk, can you elaborate on why this update is needed?

sahilk commented 2 weeks ago

Not needed. Just a clean up. I was looking to use the logo as part of some documentation and realised there were too many layers and clips in the avg making it unnecessarily large and messy. You can choose to reject it.

ejona86 commented 2 weeks ago

The preview makes it look like the new file deletes a transparency gradient.

sahilk commented 1 week ago

@ejona86 Yeah, GH's rendering is showing the dithering for some reason. The gRPC website doesn't show this detail however and I only realized there were all these layers when I opened the SVG in Figma and tried selecting a layer. IMO, it doesn't need all the layers.

ejona86 commented 1 week ago

I agree that I don't see transparency on grpc.io, but I do see a gradient. I do agree this modified one is cleaner in the file, but it is also a different image. 19 KiB is a small enough image these days and that is much smaller than the png we use, that it's not worth optimizing if it changes the resulting images.

Thank you all the same!