search

grpc / proposal

A repository for gRFCs
Apache License 2.0
719 stars 236 forks source link

Modern proposal for exposing client TLS cert in server-side call context in gRPC-JS #440

Open davidfiala opened 5 months ago

davidfiala commented 5 months ago

Modern proposal for exposing client TLS cert in server-side call context. Discussion on https://github.com/grpc/grpc-node/issues/2730 suggested we start here.

murgatroid99 commented 5 months ago

When I talked about editing this proposal, I was thinking about an addendum that would expand the sslPeerCertificate field in the grpc-js implementation. It's not appropriate to edit an existing proposal to propose a complete different API and implementation. Instead it would be better to have a new proposal for a change this substantial. Then after that we could edit this proposal to indicate that it has been superseded by the new one.

davidfiala commented 5 months ago

Apologies. I see the documentation in the repos. I'll revise the PR and correctly create a new proposal. Thanks for the note.

If anyone is interested in a strawman code-based proposal in the meanwhile, I've drafted what such a change could potentially look like here: https://github.com/davidfiala/grpc-node/commit/570fa81f7ae708764a6a8142a09074296e0ff678

I'd appreciate any early feedback to help ensure that we're closer to an ergonomic, agreed-upon doc! Thank you.