Open przano opened 3 years ago
Hello! Interesting. Can you check a few things for me:
addon-updater.log
)Thanks
Sorry for joining late on this issue.
I face the exact problem as above
The links in addons.txt are fine. I confirmed this by coying one of them into my browser, which opened up the addon site ok.
installed.ini is empty (0 Bytes)
addon-updater log looks like
Thanks, that log is extremely helpful to me. Unfortunately that looks like either Curse blocking connections again for you, or they are experiencing some other connectivity issue, maybe based on your location/region? But it's less likely that it's due to connectivity if this is persisting for you for a while now.
I tried to fix a different issue of the installed.ini file being cleared out accidentally with the latest version; Were you were on the latest version the first time you hit this new issue? I only ask because I didn't expect it to clear out that file like you mentioned.
On my end, I am able to update some Curse addons successfully, and my automated tests are also running successfully, which will make this hard to nail down
wow-addon-updater % python -m updater
Installing/updating addon: omni-cc to version: 9.1.0...
Installing/updating addon: gtfo to version: 4.64...
Name Prev. Version New Version
──── ───────────── ───────────
bagnon 9.1.0 Up to date
omni-cc 9.1.1 9.1.0
gtfo 4.63.7 4.64
Yes, I am on Version 1.9.2.
I first got the result
Name Prev. Version New Version
──── ───────────── ───────────
Press any key to continue . . .
on Aug 20 evening after a last successful attempt on Aug 16 evening. On Aug 21 and Aug 22 I tried to update unsuccessfully in the morning. Right now on the evening of Aug 22 I am able to update some addons. I seems like an issue on Curse's side.
There are some entry in the addon-updater.log that may (or may not) be helpful. Thank you anyway for your great addon!
I've been having the same problem for a few days. I did pipenv update
, but still nothing. My installed.ini is blank now but was fine in the past.
Here's the contents of my addon-updater.log:
The bug that involves "clearing out" the installed.ini file is actually totally harmless and doesn't affect anything. Just means the script may download addons a second time even though it doesn't have to. I'll take a better shot at fixing it once I figure out why Curse just closed the doors on us.
So I have good news and bad news. The good news is that I have actually fixed the bug that resets the installed.ini file. The bad news is the following error message:
Detected a Cloudflare version 2 challenge, This feature is not available in the opensource (free) version.
Meaning that it looks like I just started hitting this today, and everyone else in this thread is also probably hitting this "upgraded" Cloudflare challenge. The author of the library we depend on in this project has started charging money if you want to solve these new challenges. I'll spend some time looking for alternatives.
That's very unfortunate, it started for me yesterday. How frustrating that this is a repeatedly solvable problem that they keep making us jump through hoops for.
Here is the official position of the person who maintains the library in question: https://github.com/Anorov/cloudflare-scrape/issues/406#issuecomment-755756639
Since my initial posting, I've been observing that that this issue is intermittent. Sometimes it works, sometimes it gives the issue. Just this morning, ran it and it worked. However, it acted like it installed all of them from scratch.
I think the correct approach going forward for this project is to do one of two things:
Either
Find and implement an alternative cloud flare challenge solver. Something like https://github.com/FlareSolverr/FlareSolverr . Downsides of this approach is that I worry getting most users to install/configure their computer for Docker to run is going to be difficult (and slow, and resource-hungry). And at the end of the day, this is the same fundamental problem where cloudflare could break the workaround at any time.
Switch to using the Curse API. This requires a lot of coordination and I see most projects manually maintain a mapping of API slugs to achieve this. This is new territory for this project so it could be a bit of work. Downsides are the mapping and the actual state of Curse could drift, so it has to be updated somehow.
And in the worst case, there are some alternative CLI-based tools that users of this project can switch to in the meantime (and come back here and post any recommendations :smile: ). I looked around and a few stuck out to me:
https://github.com/antiwinter/wowa https://github.com/layday/instawow https://github.com/AcidWeb/CurseBreaker
This author does a nice job collecting some active projects:
yep worked for me this morning too
hoping it keeps working, I really like this updater, it's so easy
@grrttedwards I think I speak for everyone here.. we really appreciate how active you are in this project, and tirelessly endeavoring to solve the problems we post here. Does not go unnoticed man. You've done good stuff here. Thank You!
Similar issue here. Just attaching my log file since I'm actually getting different error conditions from the other log files, I'm just getting 403 errors. Perhaps this is related to the thread pool making many requests rapidly.
I've updated the code to try with only 1 thread in the pool, but it has not resolved the issue for me right now. Possibly this is because I'm already flagged as a sender of abusive requests on their side. I'll keep it on a single thread for a while to try that out further.
I have updated my addons a few weeks ago and had no issues then, so the intermittent nature of this issue still seems to be true.
This utility was working just fine up until today. Now when I run the .bat file, I get this in the terminal windowL
Name Prev. Version New Version ──── ───────────── ─────────── Press any key to continue . . .