search

grrttedwards / wow-addon-updater

Python utility for updating World of Warcraft addons
GNU General Public License v3.0
71 stars 14 forks source link

Feature: Also include github branches named 'main' #206

Open finkbyter opened 1 year ago

finkbyter commented 1 year ago

Hey there,

first of all I wanted to thank and hug you - your Python magic is charming! hug

I noticed that in site\github.py you are checking for "/archive/master.zip" & "/commits/master". When I was trying to update TipTac Reborn (https://github.com/frozn/TipTac) the zip URL could not be fetched. Now I wasn't digging too deep but I think adding 'main' for getting the zip URLs on github may be a cool feature!

Thanks again mate!

grrttedwards commented 1 year ago

Hi, this is a good suggestion, which can probably be implemented easily. I subbed last month for DF prepatch, which inspired my recent project updates. But, I don't have a machine to play on for a few months. I wonder if it should ask GitHub what the default branch is instead of assuming any particular branch name, or requiring you to specify it as input?

finkbyter commented 1 year ago

Defaulting to the default project branch sounds very good. You could also add an option for overwriting the default branch option while parsing 'addons.txt" https://github.com/grrttedwards/wow-addon-updater ; main https://github.com/grrttedwards/wow-addon-updater ; dev