search

grssam / UIEnhancer

Source code for UI Enhancer addon
https://addons.mozilla.org/en-US/firefox/addon/ui-enhancer/
51 stars 22 forks source link

vertical alignment of text in location bar #118

Open bit-hug opened 10 years ago

bit-hug commented 10 years ago

Hi!

Thanks!

I just found your add-on and love it, I can't believe it's taken me this long to find this. Even for the ease of sibling & parent navigation alone it's worth it and I'd often had the thought in the back of my mind that that'd be a really handy feature.

The Issue

Anyway, to business. Like serioga in #51 I had an issue with long urls hiding domain names and fixed it with the extensions.UIEnhancer.useIdentityEverytime preference. However, this highlighted another problem (although it was already evident on ssl sites). The issue is the vertical alignment of text in the location bar. Firefox vertically centres the domain text in the ID box, which looks fine. However, your add-on seems to align the text to the top of the location bar, which is unsightly. It would be nice if the text in the location bar were centred vertically (personal preference), and it would look good if the text in the location bar were vertically aligned with the firefox ID box text (good practice). In this case those two criteria coincide. Please could you incorporate this stylistic feature into the add-on? If not, please can you help me to amend the css to vertically centre the text in the location bar?

I've attached three screenshots — one of my preferred text size and preset style, one of the same style with xx-small font size to emphasize the problem described above, and one with the DevtoolsLight style and xx-small font size to show that the problem is not due to the style.

Screens:

screen shot 2014-08-07 at 15 52 52 screen shot 2014-08-07 at 15 55 25 screen shot 2014-08-07 at 16 03 46

Location Bar Enhancer 5.1 Firefox 31.0 OS X 10.8.5

Many thanks & kind regards, bit-hug.

jerone commented 10 years ago

Related: https://github.com/scrapmac/UIEnhancer/issues/115 & https://github.com/scrapmac/UIEnhancer/issues/116 & https://github.com/scrapmac/UIEnhancer/issues/102

bit-hug commented 10 years ago

Yes, I didn't notice that before. Toggling the add-on from enabled to disabled and back illustrates clearly the change in height of the location bar. (As an aside, this clarity of demonstration is only possible because the add-on is restartless, which is nice in itself!)

bit-hug commented 10 years ago

Also when australis shows the forward button and you click on the location bar to edit the url the forward button shrinks — is this a side-effect to the solution for #102? By the way, why does the location bar need to be taller in the first place?

mzso commented 9 years ago

For me on windows it also changes the height of the urlbar when I click into/out-of it. Which was pretty annoying because it made the tabbar and other stuff under it jump. I fixed the urlbar height to a static value with custom css. No clue what to do with the text alignment though.

mzso commented 9 years ago

Does anyone have a CSS fix for this until it's actualy fixed?

bit-hug commented 9 years ago

Also related: #133

rugk commented 8 years ago

Any news?