grssam / UIEnhancer

Source code for UI Enhancer addon
https://addons.mozilla.org/en-US/firefox/addon/ui-enhancer/
51 stars 22 forks source link

Request: e10s Support #154

Open JanHBade opened 7 years ago

JanHBade commented 7 years ago

https://wiki.mozilla.org/Firefox/multiprocess

mzso commented 7 years ago

It's compatible enough to function. So I don't see an issue. I've been using it for years with multiple processes.

physkets commented 7 years ago

But the 'Add-on Compatibility Reporter' add-on marks it as being incompatible.

JanHBade commented 7 years ago

and when not all addons compatible Firefox dont switch in the new MutiThreading Mode...

I think this is a big issue...

grssam commented 7 years ago

@JanHBade Then we should mark this addon as compatible. Unless you give me specifics about why its incompatible

mzso commented 7 years ago

@physkets commented on 2016. nov. 24. 05:17 CET:

But the 'Add-on Compatibility Reporter' add-on marks it as being incompatible.

So? It's a kludgy, silly system. Addons are only marked compatible only when the author specifies it. (Whether it's actually compatible or not)

@JanHBade commented on 2016. nov. 24. 07:11 CET:

and when not all addons compatible Firefox dont switch in the new MultiThreading Mode...

I think this is a big issue...

It more certainly isn't. Just use browser.tabs.remote.force-enable;true The setting is specified in the wiki page you linked.

physkets commented 7 years ago

So? It's a kludgy, silly system. Addons are only marked compatible only when the author specifies it. (Whether it's actually compatible or not)

True, so if it is actually compatible, it would be nice if the author marked it so (of course, after appropriate testing)

grssam commented 7 years ago

True, so if it is actually compatible, it would be nice if the author marked it so (of course, after appropriate testing)

Any docs on how to do that?

ullebe1 commented 7 years ago

Any docs on how to do that?

https://developer.mozilla.org/en-US/Add-ons/Install_Manifests#multiprocessCompatible

physkets commented 7 years ago

@grssam So were you able to verify if it actually is e10s compatible?

JanHBade commented 7 years ago

any update here?

sdar commented 7 years ago

I've found some issues if shims are disabled, but i don't have time atm to look at it, so it's probably not 100% compatible but it's very close.

Still firefox 57+ will create a lot of problems for keeping this addon working (and it'll work only on unstable releases).

kstev99 commented 7 years ago

Is a Web Extensions version possible ?

mzso commented 7 years ago

@kstev99 commented on 2017. okt. 7. 16:41 CEST:

Is a Web Extensions version possible ?

I'm quite sure it's not.