grssam / UIEnhancer

Source code for UI Enhancer addon
https://addons.mozilla.org/en-US/firefox/addon/ui-enhancer/
51 stars 22 forks source link

Allow usage of secured identity box via hidden pref. #37

Closed grssam closed 12 years ago

grssam commented 12 years ago

Hi, I guess you are the one reviewing on the addon.mozilla.org page for this addon ? Please lets continue the talk here instead of the reviewing page

cmlx commented 12 years ago

Yep, that's me. I tried some combination of about:config ...

"extensions.UIEnhancer.useIdentityBox;true" & "extensions.UIEnhancer.useIdentityEverytime;false" NOT work.

"extensions.UIEnhancer.useIdentityBox;true" & "extensions.UIEnhancer.useIdentityEverytime;ture" still NOT work.

grssam commented 12 years ago

Here, when both true, it works for me: https://dl.dropbox.com/u/3250186/1.png Can you post a screenshot when both the prefs true ?

cmlx commented 12 years ago

Well, it seems you don't understand what I mean:

Both prefs are true: http://dl.dropbox.com/u/11496576/2012-06-25%2018.59.38.png

HTTP web, domain name and "web" are both displayed in identitybox: http://dl.dropbox.com/u/11496576/2012-06-25%2019.00.10.png example: appbrain.com

HTTPS web with all contents SSL encryped and ID verified, domain name and "Trusted" are both displayed in identitybox: http://dl.dropbox.com/u/11496576/2012-06-25%2019.00.39.png example: github.com

HTTPS web with all contents SSL encryped, domain name and "Secure" are both displayed in identitybox: http://dl.dropbox.com/u/11496576/2012-06-25%2019.00.54.png example: dropbox.com

HTTPS web with NOT all contents SSL encryped, domain name and "Mixed" are both displayed in identitybox, and url breadcrumb cannot show correctly: http://dl.dropbox.com/u/11496576/2012-06-25%2019.01.11.png example: google reader

grssam commented 12 years ago

HTTP web, domain name and "web" are both displayed in identitybox: http://dl.dropbox.com/u/11496576/2012-06-25%2019.00.10.png example: appbrain.com

The "Web" is due to your other add-on. Otherwise, my addon is doing exactly what you wanted, to use the Identity box even for secured sites with certificate.

HTTPS web with all contents SSL encryped and ID verified, domain name and "Trusted" are both displayed in identitybox: http://dl.dropbox.com/u/11496576/2012-06-25%2019.00.39.png example: github.com

Same as above.

HTTPS web with all contents SSL encryped, domain name and "Secure" are both displayed in identitybox: http://dl.dropbox.com/u/11496576/2012-06-25%2019.00.54.png example: dropbox.com

Same.

HTTPS web with NOT all contents SSL encryped, domain name and "Mixed" are both displayed in identitybox, and url breadcrumb cannot show correctly: http://dl.dropbox.com/u/11496576/2012-06-25%2019.01.11.png example: google reader

Refer to issue 27 , https://github.com/scrapmac/UIEnhancer/issues/27#issuecomment-5966737.

When the Location Bar size is so small that even one breadcrumb will not fit, I revert back to the normal url, so that the user knows where he is instead of just having a blank urlbar.

cmlx commented 12 years ago

Thanks for the quick reply.

The characters of "Web" / "Trusted" / "Secure" / "Mixed" are not from other add-on, they are just from a userstyle (css) here: http://userstyles.org/styles/59403/firefox-operalike-text-field

Since the domain name, such as "GitHub, Inc. (US)" here, is too long to occupy the IdentityBox, I just want "Trusted" to show in IdentityBox, rather than the full domain name, and even full domain name + "Trusted", they are tooooooo long for me.

If I set "extensions.UIEnhancer.useIdentityBox;false", all HTTP websites can only show "Web" in IdentityBox without the full domain names, that's what I REALLY want. However, all HTTPS websites still show full domain names AND "Trusted" in IdentityBox, you told me this design is for convenient SSL recognition, (which is not useful for me, because I have already used a userstyle (css) to do so), then I request a hidden pref to disable this function, to hide all full domain names in IdentityBox for both HTTP and HTTPS websites. So it seems the new hidden pref should be "extensions.UIEnhancer.useIdentityNOTIME", rather than "extensions.UIEnhancer.useIdentityEverytime", and set the default value to false to make other users recognize SSL easily.

I'm so sorry for my bad English to confuse you. Thank you very much.

grssam commented 12 years ago

Ah.. you needed to remove the certificates and everything.. But I guess, except for the styling issue, your problem is in one sense, solved. Isn't it ? You are no longer seeing the certificate and country name in the identity box.

cmlx commented 12 years ago

Well, I still see the whole domain name, such as "GitHub, Inc.(US)" in the box, It's too long, so the blank area of my location bar became so small...

grssam commented 12 years ago

The screenshots that you provided, I cannot see the full "Github, Inc.(US)", instead I see the domain name github.com in the identity box

cmlx commented 12 years ago

Well, well, well, finally I know what makes you confusion about my request.

For HTTPS websites, now I could get this: http://dl.dropbox.com/u/11496576/2012-06-26%2019.20.50.png

But actually, I REALLY want this: http://dl.dropbox.com/u/11496576/2012-06-26%2019.22.25.png

Just like the change for HTTP websites, "extensions.UIEnhancer.useIdentityBox;true" show this: http://dl.dropbox.com/u/11496576/2012-06-26%2019.24.52.png

"extensions.UIEnhancer.useIdentityBox;false" show this: http://dl.dropbox.com/u/11496576/2012-06-26%2019.25.36.png

grssam commented 12 years ago

so you really want a pref like hideIdentityBox ?

cmlx commented 12 years ago

Yes, or "extensions.UIEnhancer.useIdentityBox;false" can do the same function for both HTTP and HTTPS