search

grssam / UIEnhancer

Source code for UI Enhancer addon
https://addons.mozilla.org/en-US/firefox/addon/ui-enhancer/
51 stars 22 forks source link

Pinned Tabs, new tab #47

Closed Kamui-Solo closed 11 years ago

Kamui-Solo commented 11 years ago

For example we have | github.com > scrapmac > UIEnhancer > issues | in adressbar and I press RMB on "UIEnhacer" and select adress | github.com > scrapmac > User-Style-Manager | then if tab is not pinned, new adress will be loaded in current tab, but if tab is pinned then will be opened new tab for this adress. Generally when switching one-level adresses in pinned tab, then new tab is opened.

grssam commented 11 years ago

Do you want it to be opened in new tab, or not. BTW, this is a Firefox feature, that changing location without typing, or clicking an html link opens the location in a new tab.

Kamui-Solo commented 11 years ago

No, I don't want it to be opened in new tab. i just want same behavior like not pinned tabs.

grssam commented 11 years ago

I tried to implement this, but right now, there seems no way to do this. Pushing to 5.2

Kamui-Solo commented 11 years ago

May be related issue, when press middle mouse button on some part of adress, new tab is opened, but it's opened far right of all tabs, although it must be opened right to current. In about:config browser.tabs.insertRelatedAfterCurrent;true I think opened tab isn't considered child of current tab, but it must. It happens on all tabs, pinned and not.

grssam commented 11 years ago

Yes, you are right. Thankfully fixing that will not require any string change, so I can take it up in this update :)

Kamui-Solo commented 11 years ago

Again about pinned tabs, I looked to behaviour of firefox and it looks very strange: I open google search, when tab is not pinned all links loads in current tab, when tab is pinned and I open external link, it's opened in new tab, when i press "pictures" link, url is loaded in current tab, but when I press "maps" link, it's opened in new tab. So I think it's really firefox's issue.

grssam commented 11 years ago

Actually, true.

When I tried to run this code : window.openUILinkIn(, "current");

from scratchpad in browser context on a pinned tab, then it opens in same tab, while when I use the same code in LBE, it opens in diff tab.

On Tue, Dec 4, 2012 at 6:45 PM, Kamui-Solo notifications@github.com wrote:

Again about pinned tabs, I looked to behaviour of firefox and it looks very strange: I open google search, when tab is not pinned all links loads in current tab, when tab is pinned and I open external link, it's opened in new tab, when i press "pictures" link, url is loaded in current tab, but when I press "maps" link, it's opened in new tab. So I think it's really firefox's issue.

— Reply to this email directly or view it on GitHubhttps://github.com/scrapmac/UIEnhancer/issues/47#issuecomment-10996045.

Girish Sharma B.Tech(H), Civil Engineering, Indian Institute of Technology, Kharagpur

grssam commented 11 years ago

Actually, since it is impossible to solve further, closing this one. Pinned tabs have buggy behavior using JavaScript.