search

grssam / UIEnhancer

Source code for UI Enhancer addon
https://addons.mozilla.org/en-US/firefox/addon/ui-enhancer/
51 stars 22 forks source link

Location Bar Enhancer High CPU Usage #92

Open sgtbyrd opened 11 years ago

sgtbyrd commented 11 years ago

As the title says, when the Location Bar Enhancer add-on is active it causes CPU usage to be at least 30x normal idle usage.

The extra usage depends on the address in the currently active tab's location bar. The more directories in the path, the worse the extra CPU usage. For example, "bbc.co.uk/news/england/london" causes ~100x idle usage. While pages with no location bar (such as about:addons) have no problem.

Testing:

All add-ons disabled: unable to reproduce issue, idle CPU usage is normal. Only Location Bar Enhancer enabled: issue always present.

Location Bar Enhancer Settings:

Breadcrumbs user interface: active Use new interface for the breadcrumbs: yes Show the page loading progress in the location bar: yes Show the status in the location bar: no

System:

Win 7 x64, Core i3 2120 @3.3ghz, 8GB RAM. Firefox version: 22.0 Location Bar Enhancer version: 5.1

grssam commented 11 years ago

Can you give me a profile using the profiler add-on ?

sgtbyrd commented 11 years ago

@scrapmac sure, can you give me a link to the profiler add-on you want me to use.

grssam commented 11 years ago

https://addons.mozilla.org/en-us/firefox/addon/gecko-profiler/

sgtbyrd commented 11 years ago

@scrapmac that add-on isn't available for Firefox v22

Screen

grssam commented 11 years ago

You can directly try the addon from the repository : https://github.com/bgirard/Gecko-Profiler-Addon/raw/master/geckoprofiler_amo.xpi

sgtbyrd commented 11 years ago

@scrapmac Ok, hoping I did this right. I enabled the Location Bar Enhancer add-on and reproduced the problem, I then clicked Analyse in the profiler add-on, then I saved that profile.

Here is that profile (zipped): http://www.mediafire.com/?9kdvnownim74skm

grssam commented 11 years ago

Umm, instead of saving it to local, can you share it instead. This way, I have no way to put it back into the UI to have a look into it. But if you share, it will give you the link which you can give me here.

sgtbyrd commented 11 years ago

@scrapmac here you go: http://people.mozilla.com/~bgirard/cleopatra/#report=b675eb7f12863034c80dbfdc01f431c2cad94664

grssam commented 11 years ago

Are you sure that during the time of recording this profile, your CPU usage was 100% and that you have my ad-on enabled ? Because this profile is so smooth and normal. Only the paint events are taking up time and moreover, I can see Scriptish and SBP like add-ons in the stack too. Can you give me a profile in which :

  1. You have only my add-on enabled, and
  2. You can see high CPU usage.
sgtbyrd commented 11 years ago

@scrapmac Allow me to clarify, my normal idle CPU usage for Firefox is ~0.1%. When the add-on is enabled and the current tab has a location bar, CPU usage stays constantly around 10%. Firefox never goes above 25%, I'm assuming because it sticks to one processor thread.

I don't have Scriptish, but I do have Greasemonkey. I don't know what you mean by SBP, but if you meant ABP, yes, I have Adblock Plus.

I did a profile where only two add-ons were enabled, Gecko Profiler and Location Bar Enhancer. The problem is still present.

When I try to take a profile now I get the following error: "Could not understand response from symbolication server at http://symbolapi.mozilla.org/"

So I'm not sure how easy to read this latest profile will be: http://people.mozilla.com/~bgirard/cleopatra/#report=857b96992e862b265dd894578f5f4a5ba87cf4a5

grssam commented 11 years ago

I am sorry, but I cannot see why this profile will have high CPU because of my add-on. I am trying to find any function call from one of my scripts, but I could not find one. I am really sorry about your issue, but unless I am able to identify the main cause, I cannot be of any help.

sgtbyrd commented 11 years ago

I did a little more testing and I think the problem is with the "new interface" for the breadcrumbs.

When I disable the option for "Use the new Interface for the Breadcrumbs", the problem is completely gone.

I've only noticed this problem in Firefox 22.0 as well. I've used this add-on for months with previous versions with absolutely no problems.

grssam commented 11 years ago

Oh, that is very unfortunate that this happens only in Fx 22 onwards. Lets see if other people also face this issue. Maybe more reports will help narrow down the actual issue. Can you do one more thing please: Go to about:config page and search for uienhancer. All the uienhancer related configs will be shown, then send me a screenshot of that page.

sgtbyrd commented 11 years ago

@scrapmac here you go

screen

shobits1 commented 11 years ago

I'm having the same problem; when Location Bar Enhancer is active my FF22 uses 10-25% of the CPU, this problem arisen after updating Firefox or maybe after I installed the FT DeepDark theme (I don't know for sure).

well, after playing around with the options of the Location Bar Enhancer I found that Default styles (Default Light and Default Dark ) are the responsible of this high CPU usage (maybe they are buggy of have conflict with the FF22 or FT DeepDark theme I don't know).

for now I'm using the DevTools Light style with no problem; FF22 uses about 3% of the CPU on an old computer, but what I need is a Dark style to fit with my FF theme.

grssam commented 11 years ago

Its now even more confusing that @shobits1 is having no issues with Devtools Light theme while @sgtbyrd is having issues. @shobits1 do you also have the show status bar in location bar enabled ? Or in other words, can you also send me a similar screenshot of the about:config page like @sgtbyrd did ?

shobits1 commented 11 years ago

no; I have show status bar in location bar disabled.

ff1

sgtbyrd commented 11 years ago

@scrapmac I didn't say Devtools light caused issues for me. I never even tried changing the style when the "new interface for breadcrumbs" is active. I just used the default one (Default Light I believe).

I have now tested the other styles. Default Light and Default Dark both cause the issue, Dannah's Light and Devtools Light both are fine, they never cause the issue.

grssam commented 11 years ago

Thanks! Now at least its comforting that the new users will not be seeing this issue as the default theme is now "DevTools Light" since version 4.8 or something. I will still look into this using Firefox 22 and the two styles that you mentioned to see where the CPU is being used up.

sgtbyrd commented 11 years ago

@scrapmac oh I discovered another fact of questionable usefulness.

If I have Firefox open in 2 windows at the same time, the problem is cured.

grssam commented 11 years ago

Say Wut ? o.O

sgtbyrd commented 11 years ago

@scrapmac If I open a new window (Ctrl+N), the problem goes away when the location bar in the second window displays breadcrumbs.

It confuses me as well.

grssam commented 11 years ago

I got what you said the first time, but I was amazed to hear that :)

sgtbyrd commented 11 years ago

@scrapmac I was amazed to discover it (accidentally). This bug is weird.

leaumar commented 11 years ago

Same problem here, also with both strange fixes. Any chance this could get fixed soon please? Default Dark is the only style that fits a dark FF theme and it's been a month now. I miss this add-on.

grssam commented 11 years ago

I tried debugging it once using the dark theme and dark FF firefox theme, but no luck on the high cpu. Can you guys see if the high CPU issue exists on Firefox 23 also ?

Right now I am a bit overloaded with different projects. I will take out some time for completing the next update of this add-on maybe this weekend or the next.

sgtbyrd commented 11 years ago

@scrapmac

When Firefox 23 enters release channel I'll try it. Currently my bandwidth is a little limited for downloading beta.

grssam commented 11 years ago

Sure, that happens this Monday itself :)

leaumar commented 11 years ago

First off, sorry for the dozens of edits to this post... I like to report live :)

Second, I may have found something interesting... And weird.

I took the Default Dark code, turned the rgb() statements into hex colors, then ran the code through http://www.deancasalena.com/tools/csscompact/. The resulting code, when applied as a custom sheet, fixed the high CPU usage until the moment a new tab was opened. Opening the tab caused a sine-like wave of high and low CPU usage, then loading a page brought it up to its constant high level.

I have no idea what's going on but maybe you can see a clue in that?

leaumar commented 11 years ago

Found it!

In addition to my previous post (which I won't edit anymore now), I removed the background-size statements. That fixed the CPU usage, though now of course the arrows in the background of the bar are too large. Can't they be scaled to the right, fixed size as images instead of using CSS to scale them though? Or can the height of the URL bar vary?

grssam commented 11 years ago

Hmm, not sure right now. I will have a look. Thanks for finding out the culprit :)

leaumar commented 11 years ago

This issue still exists in FF 23... You asked to be told about that

leaumar commented 10 years ago

Any news on this yet? :( Standard URL bar becomes so clunky and unusable once you've had this add-on for a while

DmitriK commented 10 years ago

Just chiming in to say I have the same issue on Firefox 24 (beta 10).

MyXelf commented 10 years ago

Still having this issue with Firefox 24.0, in my case with a 50% CPU usage.

AlexEndris commented 10 years ago

I'm also having this issue. Nothing has changed yet, only using not the default dark theme helps but since everything wouldn't be readable anymore... well you can figure.

AlexEndris commented 10 years ago

There doesn't seem to be any more development on this, as it seems. 4 Months and no response yet. :(

leaumar commented 10 years ago

Well, he can't fix what he can't reproduce...

Scrapmac, why don't you just test the issue on the computer of someone you know if your own doesn't have it?

grssam commented 10 years ago

If anyone with this issue is ready to let me use his computer for a while using teamviewer and all . then I don't have any problem with that.

leaumar commented 10 years ago

I volunteer

grssam commented 10 years ago

Email me the suitable time for you and the teamviewer details. Also, I will not be able to do this before 11th as my internet speed will get back up on 11th.

leaumar commented 10 years ago

What's your email address?

Edit: found it

leaumar commented 10 years ago

This issue still exists in the latest Firefox and Palemoon... Any news on a fix? :(

RedX2501 commented 10 years ago

Also still present for me when using any of the two default themes. The other two themes do not increase CPU usage.

Setup:

Application Basics

Name: Firefox Version: 30.0 User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0

Crash Reports for the Last 3 Days

All Crash Reports

Extensions

Name: Adblock Plus Version: 2.6.3 Enabled: true ID: {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}

Name: Close n forget Version: 0.11.6 Enabled: true ID: closeforget@addons.mozilla.org

Name: Ghostery Version: 5.3.2 Enabled: true ID: firefox@ghostery.com

Name: HTTPS-Everywhere Version: 3.5.3 Enabled: true ID: https-everywhere@eff.org

Name: LiveClick Version: 1.0.0b4 Enabled: true ID: {d166ee2a-36bb-4f33-aff7-e85f912df509}

Name: Location Bar Enhancer Version: 5.1 Enabled: true ID: UIEnhancer@girishsharma

Name: NoScript Version: 2.6.8.33 Enabled: true ID: {73a6fe31-595d-460b-a920-fcc0f8843232}

Name: Stylish Version: 1.4.3 Enabled: true ID: {46551EC9-40F0-4e47-8E18-8E5CF550CFB8}

Name: Tab Mix Plus Version: 0.4.1.4 Enabled: true ID: {dc572301-7619-498c-a57d-39143191b318}

Name: Tree Style Tab Version: 0.14.2014051101 Enabled: true ID: treestyletab@piro.sakura.ne.jp

Name: Adblock Edge Version: 2.1.3 Enabled: false ID: {fe272bd1-5f76-4ea4-8501-a05d35d823fc}

Name: Dictionary Switcher Version: 1.3.3 Enabled: false ID: dictionary-switcher@design-noir.de

Name: Download Manager Tweak Version: 1.0.6 Enabled: false ID: {F8A55C97-3DB6-4961-A81D-0DE0080E53CB}

Name: DownThemAll! Version: 2.0.17 Enabled: false ID: {DDC359D1-844A-42a7-9AA1-88A850A938A8}

Name: easy Xdebug Version: 1.5 Enabled: false ID: info@elime.be

Name: Firebug Version: 2.0.2 Enabled: false ID: firebug@software.joehewitt.com

Name: Firefox Synchronisation Extension Version: 7.3.4.76 Enabled: false ID: {A27F3FEF-1113-4cfb-A032-8E12D7D8EE70}

Name: Html Validator Version: 0.9.5.8 Enabled: false ID: {3b56bcc7-54e5-44a2-9b44-66c3ef58c13e}

Name: Link Alert Version: 1.0.2 Enabled: false ID: linkalert.conlan@addons.mozilla.com

Name: Password Exporter Version: 1.2.1 Enabled: false ID: {B17C1C5A-04B1-11DB-9804-B622A1EF5492}

Name: ProxTube - Unblock YouTube Version: 1.5.5 Enabled: false ID: ich@maltegoetz.de

Name: Saved Password Editor Version: 2.7.2 Enabled: false ID: savedpasswordeditor@daniel.dawson

Name: Selenium IDE Version: 2.4.0 Enabled: false ID: {a6fd85ed-e919-4a43-a5af-8da18bda539f}

Name: Selenium IDE: C# Formatters Version: 2.4.0 Enabled: false ID: csharpformatters@seleniumhq.org

Name: Selenium IDE: Java Formatters Version: 2.4.0 Enabled: false ID: javaformatters@seleniumhq.org

Name: Selenium IDE: Python Formatters Version: 2.4.0 Enabled: false ID: pythonformatters@seleniumhq.org

Name: Selenium IDE: Ruby Formatters Version: 2.4.0 Enabled: false ID: rubyformatters@seleniumhq.org

Name: SmoothWheel (mozdev.org) Version: 0.45.8.20130519.3 Enabled: false ID: {5F590AA2-1221-4113-A6F4-A4BB62414FAC}

Name: User Agent Switcher Version: 0.7.3 Enabled: false ID: {e968fc70-8f95-4ab9-9e79-304de2a71ee1}

Name: Web Developer Version: 1.2.5 Enabled: false ID: {c45c406e-ab73-11d8-be73-000a95be3b12}

Name: YouTube Center Version: 2.1.0 Enabled: false ID: jid1-cwbvBTE216jjpg@jetpack

Important Modified Preferences

accessibility.typeaheadfind: true accessibility.typeaheadfind.flashBar: 0 browser.cache.disk.capacity: 0 browser.cache.disk.smart_size_cached_value: 430080 browser.cache.disk.smart_size.enabled: false browser.cache.disk.smart_size.first_run: false browser.places.smartBookmarksVersion: 7 browser.sessionstore.postdata: -1 browser.sessionstore.upgradeBackup.latestBuildID: 20140605174243 browser.startup.homepage: about:blank browser.startup.homepage_override.buildID: 20140605174243 browser.startup.homepage_override.mstone: 30.0 browser.tabs.closeWindowWithLastTab: false browser.tabs.insertRelatedAfterCurrent: false browser.tabs.insertRelatedAfterCurrent.backup: true browser.tabs.onTop: false browser.tabs.tabMaxWidth: 175 browser.tabs.tabMinWidth: 175 dom.max_chrome_script_run_time: 40 dom.max_script_run_time: 40 dom.mozApps.used: true dom.w3c_touch_events.expose: false extensions.lastAppVersion: 30.0 gfx.blacklist.direct2d: 3 gfx.blacklist.layers.direct3d9: 3 gfx.direct3d.prefer_10_1: true network.cookie.prefsMigrated: true places.database.lastMaintenance: 1405802859 places.history.expiration.transient_current_max_pages: 70807 places.history.expiration.transient_optimal_database_size: 167772160 plugin.disable_full_page_plugin_for_types: application/pdf plugin.importedState: true print.printer_Microsoft_XPS_Document_Writer.print_bgcolor: false print.printer_Microsoft_XPS_Document_Writer.print_bgimages: false print.printer_Microsoft_XPS_Document_Writer.print_colorspace: print.printer_Microsoft_XPS_Document_Writer.print_command: print.printer_Microsoft_XPS_Document_Writer.print_downloadfonts: false print.printer_Microsoft_XPS_Document_Writer.print_duplex: 1394942010 print.printer_Microsoft_XPS_Document_Writer.print_edge_bottom: 0 print.printer_Microsoft_XPS_Document_Writer.print_edge_left: 0 print.printer_Microsoft_XPS_Document_Writer.print_edge_right: 0 print.printer_Microsoft_XPS_Document_Writer.print_edge_top: 0 print.printer_Microsoft_XPS_Document_Writer.print_evenpages: true print.printer_Microsoft_XPS_Document_Writer.print_footercenter: print.printer_Microsoft_XPS_Document_Writer.print_footerleft: &PT print.printer_Microsoft_XPS_Document_Writer.print_footerright: &D print.printer_Microsoft_XPS_Document_Writer.print_headercenter: print.printer_Microsoft_XPS_Document_Writer.print_headerleft: &T print.printer_Microsoft_XPS_Document_Writer.print_headerright: &U print.printer_Microsoft_XPS_Document_Writer.print_in_color: true print.printer_Microsoft_XPS_Document_Writer.print_margin_bottom: 0.5 print.printer_Microsoft_XPS_Document_Writer.print_margin_left: 0.5 print.printer_Microsoft_XPS_Document_Writer.print_margin_right: 0.5 print.printer_Microsoft_XPS_Document_Writer.print_margin_top: 0.5 print.printer_Microsoft_XPS_Document_Writer.print_oddpages: true print.printer_Microsoft_XPS_Document_Writer.print_orientation: 0 print.printer_Microsoft_XPS_Document_Writer.print_page_delay: 50 print.printer_Microsoft_XPS_Document_Writer.print_paper_data: 9 print.printer_Microsoft_XPS_Document_Writer.print_paper_height: 11,00 print.printer_Microsoft_XPS_Document_Writer.print_paper_name: print.printer_Microsoft_XPS_Document_Writer.print_paper_size_type: 0 print.printer_Microsoft_XPS_Document_Writer.print_paper_size_unit: 1 print.printer_Microsoft_XPS_Document_Writer.print_paper_width: 8,50 print.printer_Microsoft_XPS_Document_Writer.print_plex_name: print.printer_Microsoft_XPS_Document_Writer.print_resolution: 540221498 print.printer_Microsoft_XPS_Document_Writer.print_resolution_name: print.printer_Microsoft_XPS_Document_Writer.print_reversed: false print.printer_Microsoft_XPS_Document_Writer.print_scaling: 1,00 print.printer_Microsoft_XPS_Document_Writer.print_shrink_to_fit: true print.printer_Microsoft_XPS_Document_Writer.print_to_file: false print.printer_Microsoft_XPS_Document_Writer.print_unwriteable_margin_bottom: 0 print.printer_Microsoft_XPS_Document_Writer.print_unwriteable_margin_left: 0 print.printer_Microsoft_XPS_Document_Writer.print_unwriteable_margin_right: 0 print.printer_Microsoft_XPS_Document_Writer.print_unwriteable_margin_top: 0 privacy.donottrackheader.enabled: true privacy.sanitize.migrateFx3Prefs: true security.warn_viewing_mixed: false storage.vacuum.last.index: 1 storage.vacuum.last.places.sqlite: 1405630616

Graphics

Adapter Description: AMD Radeon HD 6800 Series Adapter Drivers: aticfx64 aticfx64 aticfx64 aticfx32 aticfx32 aticfx32 atiumd64 atidxx64 atidxx64 atiumdag atidxx32 atidxx32 atiumdva atiumd6a atitmm64 Adapter RAM: 1024 ClearType Parameters: Gamma: 2200 Pixel Structure: R ClearType Level: 100 Enhanced Contrast: 50 Device ID: 0x6739 Direct2D Enabled: Blocked for your graphics driver version. DirectWrite Enabled: false (6.2.9200.16571) Driver Date: 7-27-2012 Driver Version: 8.982.0.0 GPU #2 Active: false GPU Accelerated Windows: 0/1 Basic Blocked for your graphics driver version. Vendor ID: 0x1002 WebGL Renderer: Google Inc. -- ANGLE (AMD Radeon HD 6800 Series Direct3D9Ex vs_3_0 ps_3_0) windowLayerManagerRemote: false AzureCanvasBackend: skia AzureContentBackend: cairo AzureFallbackCanvasBackend: cairo AzureSkiaAccelerated: 0

JavaScript

Incremental GC: true

Accessibility

Activated: false Prevent Accessibility: 0

Library Versions

NSPR Expected minimum version: 4.10.6 Version in use: 4.10.6

NSS Expected minimum version: 3.16 Basic ECC Version in use: 3.16 Basic ECC

NSSSMIME Expected minimum version: 3.16 Basic ECC Version in use: 3.16 Basic ECC

NSSSSL Expected minimum version: 3.16 Basic ECC Version in use: 3.16 Basic ECC

NSSUTIL Expected minimum version: 3.16 Version in use: 3.16