search

grssam / User-Style-Manager

Source Code for the addon User Style Manager
https://addons.mozilla.org/en-US/firefox/addon/user-style-manager/
28 stars 4 forks source link

Make styles (optionally?) use AGENT_SHEET flag #56

Closed Drugoy closed 11 years ago

Drugoy commented 12 years ago

Some styles require more rights than userContent.css/userChrome.css/USM do have. Unlike the above mentioned ways (which use USER_SHEET flag) Stylish applies all styles with AGENT_SHEET flag.

Here are a few examples styles that work only in Stylish, because Firefox allows to style scrollbars only to the styles applied with AGENT_SHEET flag.

Maybe it makes sense to make this feature optional (global? or per style?), I'm not sure.

grssam commented 12 years ago

Thanks, that is why someone commented on my blog that the scroll bar style is not working. You are the man :) But how to decide when to apply AGENT_SHEET ?

Drugoy commented 12 years ago

You could apply it always, like Stylish does. Or you could make it optional (hidden pref/global/per style?), but I don't know if that would make sense.

grssam commented 11 years ago

Hi can you please have a look at #74 and respond if you can help me with it :)

Drugoy commented 11 years ago

Sure. I didn't get any notifications by github since it's update and all this new mess with "star" vs "watch" for projects, sorry.

grssam commented 11 years ago

Ah, you are back :)

grssam commented 11 years ago

But v1.0 is already out. I will suggest you to wait till v1.1 is in string freeze. and I am trying to use an issue to track that from now on.

Drugoy commented 11 years ago

Yeah, I've just noticed that, sorry for being late. Anyways, could you, please, in future provide links to the files where you have taken the strings that need to be translated? I'm asking that because you've just quoted them in issue #74 and I do not know a comfortable way for both of us to do the translation:

  1. I could just provide the translations as a comment to that issue, but then you'd have to manually create a patch for the project, based on my comment.
  2. Or if you'd somehow tell me which lines were taken from which files - I could then do a translation as a patch and just suggest it to you, so you would either accept or decline it.

Currently - I have to manually search among the files for those strings :(