grst / geos

Google Earth Overlay Server - display map overlays in Google Earth
https://grst.github.io/geos
BSD 3-Clause "New" or "Revised" License
42 stars 12 forks source link

Support serverParts in customMapSource #27

Closed nono303 closed 4 years ago

nono303 commented 4 years ago

tested for kml overlay in GE and OpenLayers (/maps.json) in browser

<?xml version="1.0" encoding="UTF-8"?>
<customMapSource>
    <name><![CDATA[OpenTopoMap]]></name>
    <minZoom>5</minZoom>
    <maxZoom>20</maxZoom>
    <tileType>png</tileType>
    <tileUpdate>IfModifiedSince</tileUpdate>
    <ignoreErrors>true</ignoreErrors>
    <backgroundColor>#00000000</backgroundColor>
    <url><![CDATA[https://{$serverpart}.tile.opentopomap.org/{$z}/{$x}/{$y}.png]]></url>
    <serverParts>a b c</serverParts>
</customMapSource>
grst commented 4 years ago

I just enabled github actions for this repo -- could you please rebase on master and make sure that all tests pass?

(Test coverage in this package is rather low, but it's better than nothing...).

Other than that, let me know when you are ready for review ;)

nono303 commented 4 years ago

if i did everything right... ready for review ^^

grst commented 4 years ago

LGTM, thanks!