search

grst / geos

Google Earth Overlay Server - display map overlays in Google Earth
https://grst.github.io/geos
BSD 3-Clause "New" or "Revised" License
42 stars 12 forks source link

Improve LevelOfDetail (lod) for tile rendering, especially for png alpha #30

Open nono303 opened 3 years ago

nono303 commented 3 years ago

Hi, As I had some trouble rendering correctly png alpha (strava, mapbuilder topo overlay, OSM gps, etc.) with geos, I had a look on how it worked for caltopo superoverlay I just made few changes on kml.py (see https://github.com/nono303/geos/commit/212a2e12f73a899f1034d6c3d31acdd5b52afe7f) and it's works great for me! mapbuilder topo overlay strava As I'm not a python developer and my fix is surely dirty, i prefer not make a PR and let U see how to do it cleanly ;)

Also, is my issue https://github.com/grst/mapsources/issues/3 related to geos or mapsources?

grst commented 3 years ago

Thanks @nono303,

Having had a quick look at your code, I'm just not sure if this is a general solution... would the required LOD not depend on the map? In that case it might be better to make it configurable via a mapsource.

In any case, feel free to send a PR - I currently don't have a lot of time to invest into this project and switched to using QGIS myself.

nono303 commented 3 years ago

Hi @grst I had a look onto the code to make a PR for Lod values on PNG alpha and bugfix for region (#31) but as I said, I’m not a python developer and it's seemed quite difficult to me.

In fact, after this code review, I just rewrite it in PHP in a half day, fixing region bug, Lod values for only overlayed sources and adding wms and some others features.

You can have a look on https://github.com/nono303/kmlsuperoverlay it mainly refer to geos ;)