grst / geos

Google Earth Overlay Server - display map overlays in Google Earth
https://grst.github.io/geos
BSD 3-Clause "New" or "Revised" License
42 stars 12 forks source link

The KML is generated using machine name not public name #9

Closed mgg-eagle closed 7 years ago

mgg-eagle commented 7 years ago

Hi there, are you able to add a new command line argument to enter the publicly available name of the server? The KML that is generated references the machine name, which my desktop client cannot see. If I manually edit the network links and change the server name then it is all good.

Thanks, Marc

grst commented 7 years ago

As of PR #8, there are the (atm undocumented) CLI parameters

--display-host geos.example.org
--display-port 443
--display-scheme https

The PR is merged, but not uploaded on pip yet. But if you use the version from git this should work.

mgg-eagle commented 7 years ago

That's cool thanks. I have installed the latest version from github, but I am getting the following error when I try and run it:

C:\Python3\Scripts>geos
  Restarting with stat
  File "C:\Python3\Scripts\geos.exe", line 1
SyntaxError: Non-UTF-8 code starting with '\x90' in file C:\Python3\Scripts\geos.exe on line 1, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details
grst commented 7 years ago

That's the windows-problem described in #5 which I cannot reproduce. As far as I understand, the problem arises when one tries to execute a binary (.exe) as a script (e.g. python geos.exe)

Could you please describe step-by-step what you have done?

mgg-eagle commented 7 years ago

Downloaded the latest version of python 3.6.1 and installed to c:\python3. Downloaded a zip file from github of your code and installed using pip. Tried to run geos as per last comment.

grst commented 7 years ago

I cannot reproduce that issue, but I now have a suspicion that it has something to do with the Flask debug mode.

Can you try the following:

mgg-eagle commented 7 years ago

That works now thanks.

grst commented 7 years ago

fyi: The cli-args are now part of the version on pip and included in the documentation.