Open githubpsyche opened 5 years ago
Hi,
thanks for reporting the issue. I don't support this project anymore, as I now believe that importing from notebooks is a bad idea. See the README for more details.
However, if you/someone creates a pull-request that addresses the issue, I am happy to merge it.
Cheers, Gregor
Cool, glad to know you'll merge it if I add a fix.
Hi, as a devoted jupyter user, I quite like nbimporter. Thanks for producing this tool.
In general, when an error gets thrown from a function defined in an imported notebook, it's harder than usual to tell what's going on - in general it seems that the traceback points at the wrong line numbers in the original notebook or perhaps at the wrong parts of the lines?
Here's an error message when I raised an error in an imported notebook:
And now here's the same one when the relevant functions are all in the same notebook instead of dispersed between two and united using nbimporter:
I'm not a confident github user so I don't know if this is the right way to report the issue, but it seemed worth at least bringing up. I could probably write up a simpler example of what I'm complaining about if need be. In general, though, in the latter case where I'm not relying on nbimporter, I'm getting very exact and clear feedback on where in my code the error is happening; a problem with nbimporter keeps this from happening successfully when I rely on it. This limits nbimporter as an development/prototyping aid.