search

grt192 / 2024-Haunted-House

MIT License
0 stars 0 forks source link

Reorganize RobotContainer.java #12

Open proan opened 4 hours ago

proan commented 4 hours ago

RobotContainer.java [https://github.com/grt192/2024-Haunted-House/blob/main/2025%20Haunted%20House/src/main/java/frc/robot/RobotContainer.java] has a bunch of mechanisms now, but they are not well organized. Please clean up the file by collecting all related code together into one place. For example, all of the port definitions should be together. So public static final int justinPort = 2; should be next to private final int satvikPort = 0;. Ultimately it'd be great to assign constants for all the used ports.

6kn4eakfr4s commented 4 hours ago

Will commit updated version after testing tomorrow

proan commented 4 hours ago

And I know the PR process was a little tedious at this stage, but it's good to get practice with modern methods and to keep any rookies from blasting a big hole in everyone else's work.