search

grtjn / marklogic-typescript-definitions

TypeScript Definition files for MarkLogic built-in functions, available as npm module
Apache License 2.0
9 stars 2 forks source link

migrated from gulp-tsc to gulp-typescript #35

Closed justinrdonnelly closed 4 years ago

justinrdonnelly commented 4 years ago

In gulp-tsc, the emitError option was used. This resulted in a little less error info at the terminal, and a return code of 0 (instead of 1). gulp-typescript has a similarly named option noEmitOnError, but it is NOT the same as gulp-tsc emitError. Toggling noEmitOnError changes the terminal output for 1 line about typescript emit. It also has no impact on the return code (always 1). Plenty of people are interested in the return code because they use a watcher, and they don't want it to stop on errors. They tend to have several recommendations, but it seems that the most preferred is gulp-plumber. If we're interested in that functionality, I can take a look at that. In the meantime, let me know if this change is OK.

grtjn commented 4 years ago

Going for what is currently most recommended seems reasonable. Gilp-plumber might be little more effort, but could be worth looking into.