search

gruehle / MarkdownPreview

Brackets extension for previewing markdown files
MIT License
278 stars 61 forks source link

Updated icon according new toolbar icon spec #13

Closed larz0 closed 11 years ago

larz0 commented 11 years ago

Hi Glenn could you merge this once NJ merges my larz/toolbar-hover on Brackets? Let me know if you have any questions.

gruehle commented 11 years ago

Awesome, thanks @larz0!

The icon looks a bit small to me. It's the same width as the extension icon, but because it is shorter and isn't solid, it looks smaller than the other extension icons. Do you think the width and height should be increased by 2 pixels?

Once this lands I'll change the ordering so the Markdown Preview icon shows up after the extension manager icon.

larz0 commented 11 years ago

No problem Glenn. I'll use the solid Markdown mark instead of increasing the width and height unless we feel it's okay to break the guideline in this context (https://github.com/dcurtis/markdown-mark).

gruehle commented 11 years ago

The solid icons looks much better. Thanks!

larz0 commented 11 years ago

Safe to merge this one too~