search

gruehle / MarkdownPreview

Brackets extension for previewing markdown files
MIT License
278 stars 61 forks source link

No horizontal rule with three hyphens #29

Closed ricardograca closed 9 years ago

ricardograca commented 10 years ago

When using only three hyphens to produce a HR: --- there is no HR on the preview.

Using any other allowed character works, e.g.: ___, ***.

If using spaces between the hyphens, then the HR appears in the preview: - - -, however three consecutive hyphens are valid according to the Markdown Documentation.

ricardograca commented 10 years ago

Ok, found the problem. This is extremely easy to fix so I'll submit a pull-request in a few minutes.

UPDATE: It's not that easy after all because there is a collision with the setext type headers. However, the code for the setext type header in marked.js is not 100% accurate. According to the syntax docs:

Any number of underlining =’s or -’s will work.

And in the code the minimum number of such characters is set to 3. I assume that "any number", means 1 or more.

So, apparently the setext header takes priority over having a HR defined as --- below a text line, right?

gruehle commented 9 years ago

@ricardograca - This was a problem with the marked.js library. The latest version of the extension, 1.0.10, has an updated version of marked.js that fixes this bug.