search

gruehle / MarkdownPreview

Brackets extension for previewing markdown files
MIT License
276 stars 61 forks source link

Upcoming Lodash 3.x Update #79

Closed marcelgerber closed 8 years ago

marcelgerber commented 9 years ago

Dear Brackets extension developer, we're planning to update the version of Lodash used in Brackets to 3.x (currently, we use 2.4.1). As we've had a look at your extension, we noticed there's some code that may cause issues while migrating. Thus, we suggest to update your extension so the migration can happen frictionless. For your extension, we've identified this issue: main.js: _.template with more than 1 parameter won't be supported any more. Instead, use the new syntax _.template(string)(data)

Further information: Lodash compatibility warnings Brackets issue about updating Lodash

marcelgerber commented 9 years ago

Lodash 3.10.0 will be used in the upcoming Brackets release 1.5 (https://github.com/adobe/brackets/pull/11474). In order for your extension to still function as it should, we advise you, dear extension developer, to update your extension.

gruehle commented 8 years ago

Fixed in 351850a0bfd75c9b90adc86a83b85e33ae255fa8