Push immediate balance and open order updates to UI from server when a trade is submitted or cancelled

gruelbox / orko

Trade on and script multiple crypto exchanges from a single user interface on desktop and mobile. In development.

GNU Affero General Public License v3.0

180 stars 63 forks source link

Push immediate balance and open order updates to UI from server when a trade is submitted or cancelled #150

Open badgerwithagun opened 5 years ago

badgerwithagun commented 5 years ago

May make slight guesses with price effects, but it will improve the apparent responsiveness of the UI.

[x] Binance
[x] Bitfinex
[ ] Coinbase Pro
[x] Complete xchange-stream PR by supporting reliable, sequential streams, then remove TODOs
[ ] Bittrex
[ ] Kucoin

badgerwithagun commented 5 years ago

This goes hand-in-hand with #53 - I think updating stuff client side is the problem. If we stopped doing this and instead pushed the update from server side, we could guarantee the sequence in which events were applied.

badgerwithagun commented 5 years ago

Add balance update streaming API to xchange-stream

badgerwithagun commented 5 years ago

OK, just Coinbase Pro to go...

badgerwithagun commented 5 years ago

I'm currently testing a change to the Binance implementation here which should reduce the number of API requests to the exchange. However, it's introduced two issues:

[ ] Occasionally missing balance updates
[ ] Starting to get rate bans from Binance (probably because open orders requests have higher weight than balance requests, and since we're no longer making the balance requests, the net weight of the requests has increased)

I'll need to back this out or resolve it before releasing 0.13.

badgerwithagun commented 5 years ago

Backed out and pushing this back for now. I'm running around in circles a bit and have more important things to work on.