[bitmex] Clean up Bitmex support and support trading/account access

badgerwithagun commented 5 years ago

Remaining primary issues:

Lots of TODOs and hacks in the code regarding XChange's inconsistent attempts to translate between contracts and currencies - XChange PR
No balances
No trade history
Metadata (precision etc) are wrong - XChange PR
Stop price not showing for open orders
API rate handling - getting bans. https://www.bitmex.com/app/restAPI

Secondary issues:

Looks like we can support idempotency for order submission (like Binance), so should enable this
The current trade UI assumes that the two sides of a currency pair are actually currencies. Need to tweak that a bit to make sense. Ideally should make it clear what's being bought or sold (contracts, worth X)
No ability to set post only/reduce only on a trade
No ability to manage leverage settings
No streaming support
No stop/limit support (requires XChange PR)

badgerwithagun commented 5 years ago

Getting an error when fetching metadata:

2019-01-11T08:40:35.463261+00:00 app[web.1]: ERROR [2019-01-11 08:40:35,462] io.dropwizard.jersey.errors.LoggingExceptionMapper: Error handling a request: badc5f5cc942e138
2019-01-11T08:40:35.463281+00:00 app[web.1]: ! java.lang.NullPointerException: null
2019-01-11T08:40:35.463284+00:00 app[web.1]: ! at com.gruelbox.orko.exchange.ExchangeResource$PairMetaData.<init>(ExchangeResource.java:185)
2019-01-11T08:40:35.463285+00:00 app[web.1]: ! at com.gruelbox.orko.exchange.ExchangeResource.metadata(ExchangeResource.java:175)

badgerwithagun commented 5 years ago

That's fixed. Next up is probably to resolve all this ugliness: https://github.com/knowm/XChange/issues/2886

gruelbox / orko

[bitmex] Clean up Bitmex support and support trading/account access #92