search

gruenwaldlk / eaw-layerz

A full reimplementation of the layer-z script as originally developed by Small_Pox and Kad_Venku. This script module allows space ships of the same GameObjectType to appear at randomised heights.
MIT License
6 stars 1 forks source link

Layer Z Script causing some units not to be added to the Freestore, perhaps causing assertion errors #3

Open soulrelic616 opened 4 months ago

soulrelic616 commented 4 months ago

Hello Kad,

I'm Creating an issue as referenced on the Discord channel.

Apparently the script is causing some units not to be added to the FreeStore, Some units will spawn from Hyperspace but stay behind and not attack the player.

The problem is resolved after removing the script all together.

The script seems to also be causing some assertion errors - unsure if these are related but mentioning them since the latest update removed the PLAYER_NEUTRAL references.

Please let me know if any further info is needed

Thanks!


[0x00004170] 03-07-2024 04:26:52,251|    *** ASSERTION FAILURE ***
[0x00004170] 03-07-2024 04:26:52,251|    Assertion failed!
Program: F:\Program Files (x86)\Steam\steamapps\common\Star Wars Empire at War\corruption\StarWarsI.exe
File: C:\BuildSystem\AB_SW_STEAM_FOC_BUILDSERV04_BUILD\StarWars_Steam\FOC\Code\RTS\GameObjectType.cpp
Line: 2471
Expr: faction != NULL

Stack:
[0x00004170] 03-07-2024 04:26:52,251|    *** ASSERTION FAILURE ***
[0x00004170] 03-07-2024 04:26:52,251|    Assertion failed!
Program: F:\Program Files (x86)\Steam\steamapps\common\Star Wars Empire at War\corruption\StarWarsI.exe
File: C:\BuildSystem\AB_SW_STEAM_FOC_BUILDSERV04_BUILD\StarWars_Steam\FOC\Code\RTS\GameObjectType.cpp
Line: 2471
Expr: faction != NULL
[0x00004170] 03-07-2024 04:26:52,258|    Adding file .\Data\Scripts\GameObject\ObjectScript_SpaceGeneric_Multilayer.lua
[0x00004170] 03-07-2024 04:26:52,258|    *** ASSERTION FAILURE ***
[0x00004170] 03-07-2024 04:26:52,258|    Assertion failed!
Program: F:\Program Files (x86)\Steam\steamapps\common\Star Wars Empire at War\corruption\StarWarsI.exe
File: C:\BuildSystem\AB_SW_STEAM_FOC_BUILDSERV04_BUILD\StarWars_Steam\FOC\Code\RTS\GameObjectType.cpp
Line: 2471
Expr: faction != NULL ```
soulrelic616 commented 4 months ago

To add to the above issue it seems both releases seem to crash the game as some units come out of hyperspace, the problem is random and temperamental. Sometimes a given unit would come in as normal but the next unit of same type would crash the game. Unsure what specific part of the code would be causing this.

gruenwaldlk commented 3 months ago

Is the crashing still an issue? I've only skimmed over the discord, but it seems to be a different problem. If it is cause by this library, I'll open a seperate ticket for that.

Apparently the script is causing some units not to be added to the FreeStore, Some units will spawn from Hyperspace but stay behind and not attack the player.

I feared that would happen with the fix for the pop-cap issue - I'm not 100% positive both can be resolved at the same time but I'll look into it some more. I'll also try to get a hold of someone at Petroglyph to shine a light on why this could be happening - I assume it has something to do with order of execution.