search

grug / data-mocks

Library to mock local data requests using Fetch or XHR
MIT License
63 stars 12 forks source link

Uses unbundled version of fetch-mock #37

Closed Ankcorn closed 5 years ago

Ankcorn commented 5 years ago

Currently fetch-mock ships a transpiled copy of its code but it is broken because of some babel wizardry. This makes data-mocks use the unbundled version of fetch-mock. This fixes https://github.com/ovotech/data-mocks/issues/36.

Ankcorn commented 5 years ago

Looks like I screwed this up by using the same branch to publish a temp version to npm to use in my project. :( Let me know if you want me to fix this!

grug commented 5 years ago

Oh hey! Sorry for being so slow to get back to you on this! I was on holiday.

Let me just have a quick look at fetch-mock today/this weekend. I think there's some movement on getting the fix for this into the fetch-mock repository. I might approve/merge this anyways for an interim fix.

Thank you so much for contributing - I really appreciate it :)

Ankcorn commented 5 years ago

Hope you had a good holiday! Hold off on merging this for now :). I need to revert some commits on my branch.

On Fri, 28 Jun 2019, 09:45 Dave Cooper, notifications@github.com wrote:

Oh hey! Sorry for being so slow to get back to you on this! I was on holiday.

Let me just have a quick look at fetch-mock today/this weekend. I think there's some movement on getting the fix for this into the fetch-mock repository. I might approve/merge this anyways for an interim fix.

Thank you so much for contributing - I really appreciate it :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ovotech/data-mocks/pull/37?email_source=notifications&email_token=ABYFHFFNFFFFDKUZDWMLFITP4XFQ7A5CNFSM4HZDVTMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYZPIUA#issuecomment-506655824, or mute the thread https://github.com/notifications/unsubscribe-auth/ABYFHFHNDQB2RU2UELGWPM3P4XFQ7ANCNFSM4HZDVTMA .

grug commented 5 years ago

I've got the workaround in master (and on NPM) now :)

Thank you so much for bringing this up - it's much appreciated :)