gruijter / com.gruijter.zigbee2mqtt

Connect Zigbee devices to Homey via Zigbee2MQTT
GNU General Public License v3.0
6 stars 10 forks source link

Feature/groups cleanup #10

Closed stefanrenne closed 1 year ago

stefanrenne commented 1 year ago

Changes:

gruijter commented 1 year ago

Getting an error

TypeError: undefined is not iterable (cannot read property Symbol(Symbol.iterator))
    at ZigbeeDevice.checkChangedOrDeleted (/app/drivers/Zigbee2MQTTDevice.js:293:24)
    at Homey.eventListenerDeviceListUpdate (/app/drivers/device/device.js:42:9)
    at Homey.emit (node:events:529:35)
    at MqttClient.handleMessage (/app/drivers/bridge/device.js:229:18)
    at MqttClient.emit (node:events:517:28)
    at MqttClient._handlePublish (/app/node_modules/mqtt/lib/client.js:1547:12)
    at MqttClient._handlePacket (/app/node_modules/mqtt/lib/client.js:535:12)
    at work (/app/node_modules/mqtt/lib/client.js:438:12)
    at writable._write (/app/node_modules/mqtt/lib/client.js:452:5)
    at doWrite (/app/node_modules/readable-stream/lib/_stream_writable.js:390:139)
gruijter commented 1 year ago

I merged your PR and made some small changes. But I will not release until above error is fixed. And when adding a new device in Homey the message 'migrating, please wait' is gone. The UI just shows the device as unavailable, so user has no clue what is going on.

Also my linter has an issue with this code (the ?). if (values?.light_mode === 'temperature') {

Can you check/fix it? PS: Im traveling this week. So will be next weekend before I have a chance to merge and test.

stefanrenne commented 1 year ago

Will do that, maybe it's a nice idea to add automatic linting to PR's?