search

grumpydev / pico8vscodeeditor

A plugin for VSCode for Pico8 development, with basic Lua language and Pico8 API support.
MIT License
25 stars 6 forks source link

Single and double quotes not recognized as string literals? #4

Open hiddenwaffle opened 5 years ago

hiddenwaffle commented 5 years ago

I noticed that string literal coloring is applied to double square bracketed strings but not single or double quoted strings. In the attached screenshot's color scheme, strings are green but the first two seem to ignore the quotes and use identifiers.

I see the single and double quotes mentioned around here, but they do not seem to take effect. https://github.com/grumpydev/pico8vscodeeditor/blob/efdb19d78acbc372bcb4fae0a9a80ca2144b72ac/syntaxes/lua.tmLanguage.json#L74

Screen Shot 2019-06-05 at 11 26 17 PM
AntonRevin commented 4 years ago

I had the same problem, fixed it in my pull request ( #6 ). If you don't want to wait for the update you can simply perform the changes I made in the commit locally.