grumpyhome / grumpy

Grumpy is a Python to Go source code transcompiler and runtime.
Apache License 2.0
420 stars 18 forks source link

Fix #82: Implement the 'reverse' option for sorted() #119

Closed alanjds closed 5 years ago

alanjds commented 5 years ago

This is the companion PR of #82: Implement the 'reverse' option for sorted()

See comments on #82, if any

Original:

google#162 opened on Jan 18, 2017 by @MirkoDziadzka

Add the 'reverse' option to 'sorted()'

I'm not sure if this violates the 'stable sort definition in Python. On the other hand, this is probably only relevant when key or cmp gets implemented.

funny-falcon commented 5 years ago

Sorry, I could not see any difference from already merged #102 , and I saw its code merged into master ... but this branch has no conflicts... What's happening? Maybe it is because I'm from phone, and web-mobile github version doesn't show me some important details?

alanjds commented 5 years ago

You are right. I was cleaning the open branches and found this one.

Forgot that the feature was already merged. Sorry and thanks for pointing.