grumpyhome / grumpy

Grumpy is a Python to Go source code transcompiler and runtime.
Apache License 2.0
420 stars 18 forks source link

fix for #17 #87

Open alanjds opened 6 years ago

alanjds commented 6 years ago

google/grumpy#265 opened on Mar 6, 2017 by @jamdagni86

This is something which I could come up with in a couple of hours. The idea is to merge the constituent tuple arguments into a single argument (by joining argument names with τ) and get them unpacked inside the function using array notation.

Let me know your thoughts on the same. Unit tests are still work in progress; will update the PR once they are ready!

alanjds commented 6 years ago

Comment by googlebot Monday Mar 06, 2017 at 19:35 GMT


Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


alanjds commented 6 years ago

Comment by jamdagni86 Monday Mar 06, 2017 at 19:40 GMT


I signed it!

alanjds commented 6 years ago

Comment by googlebot Monday Mar 06, 2017 at 19:40 GMT


CLAs look good, thanks!

alanjds commented 6 years ago

Comment by jamdagni86 Wednesday Aug 30, 2017 at 06:38 GMT


@trotterdylan - The build is failing in go 1.9 as mentioned in google/grumpy#378

alanjds commented 6 years ago

@jamdagni86: I think we fixed the compilation issues. Please let me know if you think this (#265) is good to merge, in your opinion.