Fixed dependencies and template issue

grundic / puppet-teamcity

Teamcity module for puppet

9 stars 14 forks source link

Fixed dependencies and template issue #17

Open alexqyle opened 8 years ago

alexqyle commented 8 years ago

Added anchor in class teamcity, so that it is possible to add dependencies for this module. (https://github.com/grundic/puppet-teamcity/issues/16) Fixed variable scope in build-agent-service.erb. Code was written by senax (https://github.com/grundic/puppet-teamcity/issues/13).

dploeger commented 7 years ago

I think, this should be merged. I can not access the travis logs to see, what problems were reported. @grundic Could you please look into this?

grundic commented 7 years ago

Hi @dploeger, I've restarted the job to refresh the logs. But right now I don't have much time supporting this project unfortunately.

dploeger commented 7 years ago

@grundic Thanks. If you take a look at the CI logs, it complains about open dependencies in metadata.json and an incompatibility with ruby 1.9, because the gem public_suffix needs Ruby >=2.0.0.

These were all changes, that were not introduced by this pull request.

So we either need to fix the tests and leave out Ruby 1.9 or merge this pull request. :)